GeezerVison is showing github.com — Compatibility tests: Use correct test cases object and remove invalid test case by bergmeister · Pull Request #1440 · PowerShell/PSScriptAnalyzer
Conversation
PR Summary
The $genericVerCases test case object was not being used due to what seems to have been a copy-paste error.
One test case actually did not work because having a version string with not dot would throw here
I could add the following negative test for it but was wondering why we cannot make it accept single character versions?
It "Does not parse version string '7' due to missing dot" {
{ [Microsoft.PowerShell.CrossCompatibility.PowerShellVersion] '7' } | Should -Throw
}
In the case of PowerShell Core we wouldn't even need our own implementation and just use System.Management.Automation.SemanticVersion, which can actually parse versions without a dot.
PR Checklist
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
rjmholt reacted with thumbs up emoji
Christoph Bergmeister (bergmeister)
changed the title
Compatibility tests: Use correct genericVerCases test cases and remove invalid test case
Compatibility tests: Use correct test cases object and remove invalid test case
Apr 13, 2020
I could add the following negative test for it but was wondering why we cannot make it accept single character versions?
I think that's worth doing.
That class exists to allow JSON serialisation of versions across PowerShell versions, so it's not really necessary in the tests.
Thanks for fixing this Christoph Bergmeister (@bergmeister)!
|
bergmeister reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
OK, I will merge this and open a 2nd PR later to add the capability of parsing a single character version
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.