GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Compatibility tests: Use correct test cases object and remove invalid test case by bergmeister · Pull Request #1440 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Apr 13, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

The $genericVerCases test case object was not being used due to what seems to have been a copy-paste error.
One test case actually did not work because having a version string with not dot would throw here

I could add the following negative test for it but was wondering why we cannot make it accept single character versions?

        It "Does not parse version string '7' due to missing dot" {
            { [Microsoft.PowerShell.CrossCompatibility.PowerShellVersion] '7' } | Should -Throw
        }

In the case of PowerShell Core we wouldn't even need our own implementation and just use System.Management.Automation.SemanticVersion, which can actually parse versions without a dot.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rjmholt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bergmeister
Compatibility tests: Use correct genericVerCases test case and remove…
e1e74b9
… invalid test case
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Test label Apr 13, 2020
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from Rob Holt (rjmholt) April 13, 2020 13:38
@bergmeister Christoph Bergmeister (bergmeister) changed the title Compatibility tests: Use correct genericVerCases test cases and remove invalid test case Compatibility tests: Use correct test cases object and remove invalid test case Apr 13, 2020
@rjmholt

Rob Holt (rjmholt) commented Apr 13, 2020

Copy link
Copy Markdown
Contributor

I could add the following negative test for it but was wondering why we cannot make it accept single character versions?

I think that's worth doing.

That class exists to allow JSON serialisation of versions across PowerShell versions, so it's not really necessary in the tests.

Thanks for fixing this Christoph Bergmeister (@bergmeister)!

bergmeister reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rjmholt
Rob Holt (rjmholt) approved these changes Apr 14, 2020
View reviewed changes
@bergmeister

Christoph Bergmeister (bergmeister) commented Apr 16, 2020

Copy link
Copy Markdown
Collaborator Author

OK, I will merge this and open a 2nd PR later to add the capability of parsing a single character version

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister
Christoph Bergmeister (bergmeister) merged commit 03aa085 into master Apr 16, 2020
@bergmeister
Christoph Bergmeister (bergmeister) deleted the bergmeister-patch-1 branch April 17, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.