GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update Newtonsoft.Json from 12.0.2 to 12.0.3 in Compatibility project as well by bergmeister · Pull Request #1447 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Apr 17, 2020

Copy link
Copy Markdown
Collaborator

PR Summary

PowerShell 6.2.4 uses this version as well, therefore not an issue: https://github.com/PowerShell/PowerShell/blob/v6.2.4/src/System.Management.Automation/System.Management.Automation.csproj
The upgrade to this version technically already happened in PR #1425 but this project was did not get updates.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister
Update Newtonsoft.Json from 12.0.2 to 12.0.3 in Compatibility project…
33049af 
… as well
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Build label Apr 17, 2020
@bergmeister
Christoph Bergmeister (bergmeister) requested review from James Truher (JamesWTruher) and Rob Holt (rjmholt) April 17, 2020 18:31
rjmholt
Rob Holt (rjmholt) approved these changes Apr 17, 2020
View reviewed changes
Christoph Bergmeister
Merge branch 'master' of https://github.com/PowerShell/PSScriptanalyzer…
11edf72 
… into bergmeister-patch-3
@bergmeister

Christoph Bergmeister (bergmeister) commented Apr 17, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator Author

That's funny, one of the tests jobs failed because I merged PR #1446 AFTER the build had already started, meaning that when the test job checked out out the repo, it executed the newly added tests but of course the build artefact did not have the code to make it pass that test... I suppose this does not happen very often but it's good to be aware of this because the traditional re-run of the test stage did not help here of course. Technically, we should probably upload the Tests folder as an artefact to avoid this but that would make CI unnecessarily more complex I fear.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 9098e76 into master Apr 17, 2020
@bergmeister
Christoph Bergmeister (bergmeister) deleted the bergmeister-patch-3 branch October 24, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.