GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CI: Use runtime expression syntax for passing pwsh parameter by bergmeister · Pull Request #1449 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Apr 17, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

This is due to a regression in Azure Pipelines expressions, which used to work the way they were but a few weeks ago they somehow changed their behaviour and now don't pass the parameter any more, meaning that the tests that were supposed to run on Windows PowerShell in the test matrix were actually run on PowerShell Core.
Changing to a run-time expression instead of a runtime expression for the moment to fix this
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/expressions?view=azure-devops#variables

I submitted this bug report: https://developercommunity.visualstudio.com/content/problem/996647/boolean-compile-time-yaml-expression-not-correctly.html

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister
try use bracket syntax
874ba22 
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/expressions?view=azure-devops#variables
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Build label Apr 17, 2020
@bergmeister
Christoph Bergmeister (bergmeister) requested review from James Truher (JamesWTruher) and Rob Holt (rjmholt) April 17, 2020 23:08
rjmholt
Rob Holt (rjmholt) approved these changes Apr 20, 2020
View reviewed changes
JamesWTruher
James Truher (JamesWTruher) approved these changes Apr 21, 2020
View reviewed changes
@JamesWTruher

James Truher (JamesWTruher) commented Apr 21, 2020

Copy link
Copy Markdown
Contributor

Christoph Bergmeister (@bergmeister) could you resolve the merge conflict and resubmit?
bergmeister reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister
Merge branch 'master' into bergmeister-pwsh-expression
292dee1
@bergmeister

Christoph Bergmeister (bergmeister) commented Apr 21, 2020

Copy link
Copy Markdown
Collaborator Author

James Truher (@JamesWTruher) Sure. Done. It was a trivial conflict of the artificial EOL that GitHub always adds at the end of the file when using the web editor.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 1f63688 into PowerShell:master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister @JamesWTruher @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.