GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — UseConsistentIndentation: When non-default options are used, cater for the case of a comment between pipe and newline by bergmeister · Pull Request #1463 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Apr 26, 2020

Copy link
Copy Markdown
Collaborator

PR Summary

Fixed #1459 so that indentation gets increased for setting values of IncreaseIndentationForFirstPipeline or IncreaseIndentationAfterEveryPipeline if there is a comment between pipe and newline (the comment caused it not work because it peeked only at the next token when checking for the newline or line continuation token.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christoph Bergmeister
UseConsistentIndentation: When non-default options are used, cater fo…
295c534 
…r the case of a comment between pipe and newline
@bergmeister Christoph Bergmeister (bergmeister) added Issue - Bug Area - Formatter labels Apr 26, 2020
@bergmeister
Christoph Bergmeister (bergmeister) requested review from James Truher (JamesWTruher) and Rob Holt (rjmholt) April 26, 2020 20:32
rjmholt
Rob Holt (rjmholt) reviewed Apr 27, 2020
View reviewed changes
Comment thread Rules/UseConsistentIndentation.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Christoph Bergmeister (bergmeister) and others added 7 commits April 27, 2020 17:30
@bergmeister @rjmholt
Update Rules/UseConsistentIndentation.cs
4398031 
Co-Authored-By: Robert Holt <[email protected]>
Christoph Bergmeister
re-trigger ci
65da164
Christoph Bergmeister
Merge branch 'master' of https://github.com/powershell/psscriptanalyzer…
0d3350c 
… into UseConsistentIndentation-CommentBetweenPipeAndNewline
Christoph Bergmeister
Merge branch 'UseConsistentIndentation-CommentBetweenPipeAndNewline' of
93c9450 
https://github.com/bergmeister/psscriptanalyzer into UseConsistentIndentation-CommentBetweenPipeAndNewline
Christoph Bergmeister
try split test template
226259d
Christoph Bergmeister
Revert "try split test template"
15c3435 
This reverts commit 226259d.
Christoph Bergmeister
fix syntax due to missing brace (also: GitHub suggestions did not cor…
1769764 
…rectly insert whitespaces in there)
rjmholt
Rob Holt (rjmholt) approved these changes Apr 28, 2020
View reviewed changes
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 53ece47 into PowerShell:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Formatter Issue - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Formatter fails for multi-line pipelines when the first line has two or more pipes

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.