GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use separate test.yaml files files since param passing of pwsh still doesn't seem to fully work correctly by bergmeister · Pull Request #1466 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Apr 28, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

See https://developercommunity.visualstudio.com/content/problem/996647/boolean-compile-time-yaml-expression-not-correctly.html

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christoph Bergmeister added 13 commits April 25, 2020 23:32
Christoph Bergmeister
Pass pwsh parameter explicitly as runtime parameter
92df6c4
Christoph Bergmeister
fix yaml
f270590
Christoph Bergmeister
try use compile time expression
f60a154
Christoph Bergmeister
cannot cast to bool, use string
637b3bc
Christoph Bergmeister
compile time expressions everywhere
517ba15
Christoph Bergmeister
Revert "compile time expressions everywhere"
ca76515 
This reverts commit 517ba15.
Christoph Bergmeister
runtime expr
3af2262
Christoph Bergmeister
try use $() expression and don't pass parameter
01a7d39
Christoph Bergmeister
try re-add param section
8eed77d
Christoph Bergmeister
try use bracket again
66cb8ab
Christoph Bergmeister
try split test template
fc361a3 
# Conflicts:
#	.azure-pipelines-ci/templates/test-powershell.yaml
Christoph Bergmeister
Merge branch 'master' of https://github.com/powershell/psscriptanalyzer…
5d40207 
… into ci-fix-param-passing
Christoph Bergmeister
re-enable build
90ad293
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Build label Apr 28, 2020
@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review April 28, 2020 20:37
@bergmeister
Christoph Bergmeister (bergmeister) requested review from James Truher (JamesWTruher) and Rob Holt (rjmholt) April 28, 2020 20:37
@bergmeister
remove duplicated entry
765748d
JamesWTruher
James Truher (JamesWTruher) approved these changes Apr 29, 2020
View reviewed changes

@JamesWTruher James Truher (JamesWTruher) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher
James Truher (JamesWTruher) merged commit c005599 into PowerShell:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjmholt Rob Holt (rjmholt) Awaiting requested review from rjmholt
1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.