GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — UseConsistentWhitespace: Check previous token only if it starts on the same line by bergmeister · Pull Request #1491 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented May 12, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Fixes #1490
This did not cause an issue for the formatter but for people who want to check compliance with a certain formatting definition by running Invoke-ScriptAnalyzer against them.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christoph Bergmeister
UseConsistentWhitespace: Check previous token only if it starts on th…
f99297e 
…e same line
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Rules label May 12, 2020
Christoph Bergmeister
add test
6b9fcde
@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review May 12, 2020 15:51
rjmholt
Rob Holt (rjmholt) approved these changes May 12, 2020
View reviewed changes
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request May 28, 2020
Invoke-ScriptAnalyzer: An item with the same key has already been added. What is the proper syntax? #1511
Closed
@bergmeister
Christoph Bergmeister (bergmeister) merged commit a23af17 into PowerShell:master Jun 11, 2020
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Jun 13, 2020
UseConsistentWhitespace/CheckOpenBrace false positive #1522
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PSPlaceOpenBrace and PSUseConsistentWhitespace don't work together

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.