GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — UseUsingScopeModifierInNewRunspaces: Fix ArgumentException when the same variable name is used in 2 different sessions. by bergmeister · Pull Request #1493 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented May 12, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Fixes #1492 by checking if the variable name was already added. Also simplifying the code to be a HashSet<string> instead of a Dictionary<string,VariableExpressionAst> since the actual variable seems to be never used. Unfortunately I have to drop the IReadOnlyCollection for HashSet since we target .Net 4.5.2 and only starting with .Net 4.6, HashSet is implementing IReadOnlyCollection, see here.
cc Jos Koelewijn (@Jawz84)

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christoph Bergmeister
UseUsingScopeModifierInNewRunspaces: Fix ArgumentException when the s…
a664c78 
…ame variable name is used in 2 different sessions.
@bergmeister Christoph Bergmeister (bergmeister) added Area - Rules Issue - Bug labels May 12, 2020
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request May 12, 2020
The rule 'UseUsingScopeModifierInNewRunspaces' throw an ArgumentException #1492
Closed
Christoph Bergmeister
use .add method to fix full .net build
9ae8bcc
bergmeister
Christoph Bergmeister (bergmeister) commented May 12, 2020
View reviewed changes
Comment thread Rules/UseUsingScopeModifierInNewRunspaces.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
rjmholt
Rob Holt (rjmholt) approved these changes May 12, 2020
View reviewed changes
@bergmeister
Christoph Bergmeister (bergmeister) merged commit c265f03 into PowerShell:master May 18, 2020
This was referenced May 22, 2020
UseUsingScopeModifierInNewRunspaces: Fix ThrowAddingDuplicateWithKeyArgumentException #1513
Closed
Invoke-ScriptAnalyzer: An item with the same key has already been added. What is the proper syntax? #1511
Closed
@scott1138

scott1138 commented Jun 29, 2020

Copy link
Copy Markdown

Christoph Bergmeister (@bergmeister) Rob Holt (@rjmholt) do you know when this will be added to a release?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister

Christoph Bergmeister (bergmeister) commented Jun 29, 2020

Copy link
Copy Markdown
Collaborator Author

scott1138 We hope to release this next month
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Jul 20, 2020
An item with the same key has already been added #1547
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Rules Issue - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The rule 'UseUsingScopeModifierInNewRunspaces' throw an ArgumentException

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister @scott1138 @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.