GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix bug with PipelineIndentationStyle.None where break instead of continue statement was used by bergmeister · Pull Request #1497 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented May 13, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Fixes #1496

Also added another test case that would've caught it.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister
Fix bug with PipelineIndentationStyle.None where break instead of con…
a5a2e6b 
…tinue statement was used. TODO: Fix test that starts to fail because of this now
@bergmeister Christoph Bergmeister (bergmeister) added Issue - Bug Area - Rules Area - Formatter labels May 13, 2020
@bergmeister Christoph Bergmeister (bergmeister) self-assigned this May 13, 2020
@bergmeister
fix last failing test to make None not touch existing indendation
6d0a4d2
@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review May 14, 2020 17:04
@bergmeister
Christoph Bergmeister (bergmeister) requested review from James Truher (JamesWTruher) and Rob Holt (rjmholt) May 14, 2020 17:05
This was referenced May 21, 2020
[2020.5.0] Wrong indentation #1508
Closed
Invoke-ScriptAnalyzer: An item with the same key has already been added. What is the proper syntax? #1511
Closed
Christoph Bergmeister added 3 commits June 11, 2020 21:00
Christoph Bergmeister
Merge branch 'master' of https://github.com/powershell/psscriptanalyzer…
6521ebd 
… into issue1496

# Conflicts:
#	Tests/Rules/UseConsistentIndentation.tests.ps1
Christoph Bergmeister
empty commit since Azure Pipelines did not trigger
6cf454f
Christoph Bergmeister
empty commit since Azure Pipelines did not trigger
8f6769f
rjmholt
Rob Holt (rjmholt) approved these changes Jun 11, 2020
View reviewed changes
Comment thread Rules/UseConsistentIndentation.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Rules/UseConsistentIndentation.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Rules/UseConsistentIndentation.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Rules/UseConsistentIndentation.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Christoph Bergmeister (bergmeister) and others added 2 commits June 11, 2020 21:47
@bergmeister @rjmholt
Apply suggestions from code review
82e993c 
Co-authored-by: Robert Holt <[email protected]>
@bergmeister
Apply suggestions from code review
13c5fcc
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 8e6182f into PowerShell:master Jun 11, 2020
rjmholt
Rob Holt (rjmholt) reviewed Jun 11, 2020
View reviewed changes
Comment thread Rules/UseConsistentIndentation.cs
int searchLine;
do
{
searchLine = tokens[searchIndex].Extent.StartLineNumber;

@rjmholt Rob Holt (rjmholt) Jun 11, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! My switch suggestion got lost! Ugh, too much context switching... Anyway, not an issue

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@bergmeister Christoph Bergmeister (bergmeister) Jun 11, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I addressed your comment here by not initializing it: #1497 (comment)
Or did you mean a switch around tokens[searchIndex].Kind? I don't see too much value in it tbh. Switch statements don't look that much cleaner for simple cases like that IMHO because of their ceremony that requires additional indentation layer, break statements, etc..
Otherwise we can always create a follow up PR

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Jul 20, 2020
Formatting issue with New-Object and Trim Whitespace for Props #1540
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@bergmeister Christoph Bergmeister (bergmeister)

Labels

Area - Formatter Area - Rules Issue - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PipelineIndentationStyle: Incorrect formatting when using None

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.