GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — UseConsistentWhitespace: Fix CheckParameter bug when using interpolated string by bergmeister · Pull Request #1498 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented May 14, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Fixes #1495

I thought the searchNestedScriptBlocks: false option would not make it return nested objects in commandAst.FindAll. However, for an interpolated string, the VariableExpressionAst of the ExpendableStringExpressionAst is returned as well, therefore checking that only AST are returned whose parent is the commandAst.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister
UseConsistentWhitespace: Fix CheckParameter bug when using interpolat…
1541e8d 
…ed string
@bergmeister Christoph Bergmeister (bergmeister) added Area - Formatter Issue - Bug Area - Rules labels May 14, 2020
@bergmeister Christoph Bergmeister (bergmeister) self-assigned this May 14, 2020
@bergmeister
Christoph Bergmeister (bergmeister) requested review from James Truher (JamesWTruher) and Rob Holt (rjmholt) May 14, 2020 17:07
rjmholt
Rob Holt (rjmholt) approved these changes May 14, 2020
View reviewed changes
@bergmeister
Christoph Bergmeister (bergmeister) merged commit aa66551 into PowerShell:master May 18, 2020
This was referenced Jun 17, 2020
hashtable formatting error #1530
Closed
codeFormatting.whitespaceBetweenParameter setting causing characters to be dropped from scripts #1529
Closed
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Jul 1, 2020
powershell.codeFormatting.whitespaceBetweenParameters inappropriately removes + operators in string concatenation #1536
Closed
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Jul 20, 2020
whitespaceBetweenParameters alters non-parameter's code multiple times #1541
Closed
@DarkMorford DarkMorford mentioned this pull request Aug 13, 2020
Format Document command corrupts text strings in Powershell documents PowerShell/vscode-powershell#2870
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@bergmeister Christoph Bergmeister (bergmeister)

Labels

Area - Formatter Area - Rules Issue - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CheckParameter option of UseConsistentWhitespace (off by default): When turned, on removes part of script

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.