GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Set Assembly version attribute for 1.19.1 release by JamesWTruher · Pull Request #1549 · PowerShell/PSScriptAnalyzer

Conversation

@JamesWTruher

@JamesWTruher James Truher (JamesWTruher) commented Jul 21, 2020 •
edited by bergmeister
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

this change puts an assembly version on the analyzer assemblies, so you can see the version by inspection of the assembly

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher
changes for 1.19.1 release
c41e21f
@rjmholt
Rob Holt (rjmholt) requested a review from Christoph Bergmeister (bergmeister) July 21, 2020 22:08
rjmholt
Rob Holt (rjmholt) reviewed Jul 21, 2020
View reviewed changes

@rjmholt Rob Holt (rjmholt) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also set the version for Microsoft.PowerShell.CrossCompatibility.

Ideally in future we can use a more centralised configuration, like PSScriptAnalyzer.Common.props or something, to set this in one place. We possibly also discussed a YAML configuration for this

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bergmeister reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bergmeister

Christoph Bergmeister (bergmeister) commented Jul 21, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Yes to doing it also for Microsoft.PowerShell.CrossCompatibility.dll. Please update the changelog with this PR.

I am not sure why (and if) we need the existing VersionPrefix property, which is also not present in Microsoft.PowerShell.CrossCompatibility.dll at the moment
rjmholt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister Christoph Bergmeister (bergmeister) changed the title changes for 1.19.1 release Set Assembly version attribute for 1.19.1 release Jul 21, 2020
@JamesWTruher
add version to CrossCompatibility assembly
1e89341
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Jul 22, 2020
View reviewed changes
@JamesWTruher
James Truher (JamesWTruher) merged commit 8c5a638 into PowerShell:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes
+1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@JamesWTruher @bergmeister @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.