GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix suppression example errors in README by rjmholt · Pull Request #1593 · PowerShell/PSScriptAnalyzer

Conversation

@rjmholt

@rjmholt Rob Holt (rjmholt) commented Oct 6, 2020

Copy link
Copy Markdown
Contributor

Fixes #1592

PR Summary

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rjmholt
Fix suppression example errors in README
7000304 
Fixes #1592
@rjmholt
Rob Holt (rjmholt) requested review from James Truher (JamesWTruher), Sydney Smith (SydneyhSmith) and Christoph Bergmeister (bergmeister) October 6, 2020 18:34
SydneyhSmith
Sydney Smith (SydneyhSmith) approved these changes Oct 6, 2020
View reviewed changes

@SydneyhSmith Sydney Smith (SydneyhSmith) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for making the change

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rjmholt
Rob Holt (rjmholt) merged commit d945a41 into master Oct 6, 2020
@rjmholt
Rob Holt (rjmholt) deleted the suppression-typos branch October 6, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SydneyhSmith Sydney Smith (SydneyhSmith) SydneyhSmith approved these changes
@bergmeister Christoph Bergmeister (bergmeister) Awaiting requested review from bergmeister
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error in last two SuppressMessageAttribute examples in readme.MD

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rjmholt @SydneyhSmith
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.