GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove conditional compilation for PSv6 and therefore netstandard2.0 for Engine and Rules projects by bergmeister · Pull Request #1600 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Oct 24, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

This is due to PS 6.2 having reached EOL. The Engine and Rules projects target netcoreapp3.1 for PS 7, therefore the netstandard2.0 compilation target for them is not needed any more. Because the CrossCompatility project is still generic and is not targeting netcoreapp3.1 for PS 7, we can and should keep that project using netstandard2.0.
This will make the module smaller in size and the build faster as a nice side-effect.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christoph Bergmeister
Remove conditional compilation for PSv6 and therefore netstandard2.0 …
e7779e6 
…for Engine/Rules project
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Build label Oct 24, 2020
@bergmeister
Update PSScriptAnalyzer.psm1
21ac26c
bergmeister
Christoph Bergmeister (bergmeister) commented Oct 24, 2020
View reviewed changes
Comment thread Engine/PSScriptAnalyzer.psm1
$binaryModuleRoot = Join-Path -Path $PSModuleRoot -ChildPath "PSv$($PSVersionTable.PSVersion.Major)"
}
elseif ($PSVersionTable.PSVersion.Major -eq 6 ) {
[Version] $minimumPowerShellCoreVersion = '7.0.3'

@bergmeister Christoph Bergmeister (bergmeister) Oct 24, 2020

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose to bump not just from 6.2.4 to 7.0.0 but also to 7.0.3 in anticipation of PR #1597 getting merged, which will bump the minimum version to 7.0.3. Since 7.0.2 is not supported anyway because 7.0.3 is already more than a month old, this should not be an issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rjmholt and JamesWTruher reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@bergmeister
Christoph Bergmeister (bergmeister) requested review from James Truher (JamesWTruher) and Rob Holt (rjmholt) October 25, 2020 20:51
@bergmeister
Update README.md
b969efc
JamesWTruher
James Truher (JamesWTruher) approved these changes Nov 3, 2020
View reviewed changes
rjmholt
Rob Holt (rjmholt) approved these changes Nov 3, 2020
View reviewed changes
@rjmholt
Merge branch 'master' into RemovePSV6
0fdaa45
rjmholt
Rob Holt (rjmholt) reviewed Nov 3, 2020
View reviewed changes
Comment thread Rules/Rules.csproj
<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp3.1' ">
<PackageReference Include="System.Reflection.TypeExtensions" Version="4.7.0" />
<PackageReference Include="Microsoft.Management.Infrastructure" Version="2.0.0" />
<Compile Remove="UseSingularNouns.cs" />

@rjmholt Rob Holt (rjmholt) Nov 3, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put this in the same block since the previous PR did the same, but I'd be happy to move it to its own block too

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rjmholt
Rob Holt (rjmholt) merged commit 965eca5 into master Nov 10, 2020
@rjmholt
Rob Holt (rjmholt) deleted the RemovePSV6 branch November 10, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister @rjmholt @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.