GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Replace words with racial connotation (use allowlist and blocklist as an alternative) by bergmeister · Pull Request #1604 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Oct 25, 2020

Copy link
Copy Markdown
Collaborator

PR Summary

This does not replace all words with a racial connotation because one word is the setting name of the PSAvoidUsingCmdletAliases rule. Therefore an alternative setting name is being added, whilst allowing the current one to still work. The idea is that we give users time to adapt in the next version but completely remove the setting with a racial connotation in the version after that.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christoph Bergmeister (bergmeister) added 2 commits October 25, 2020 20:10
@bergmeister
Replace words with racial connotation.
6b3db5d
@bergmeister
replace with blocklist
920402f
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from Rob Holt (rjmholt) October 25, 2020 20:50
@bergmeister Christoph Bergmeister (bergmeister) assigned James Truher (JamesWTruher) and unassigned James Truher (JamesWTruher) Oct 25, 2020
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from James Truher (JamesWTruher) October 25, 2020 20:50
@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review October 25, 2020 20:50
rjmholt
Rob Holt (rjmholt) reviewed Nov 3, 2020
View reviewed changes

@rjmholt Rob Holt (rjmholt) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only worry here is that this is a public configuration key, so that changing its name will break existing configurations

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rjmholt

Rob Holt (rjmholt) commented Nov 3, 2020

Copy link
Copy Markdown
Contributor

My only worry here is that this is a public configuration key, so that changing its name will break existing configurations

Oh I see from your description that this is an alternative!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rjmholt
Rob Holt (rjmholt) approved these changes Nov 3, 2020
View reviewed changes
@rjmholt
Rob Holt (rjmholt) merged commit 4857578 into PowerShell:master Nov 3, 2020
@bergmeister

Christoph Bergmeister (bergmeister) commented Nov 3, 2020

Copy link
Copy Markdown
Collaborator Author

Yes, it is an alternative/alias for the existing settings but once a new version of pssa is released with that, which would give people time to adapt I am tempted to remove the original setting name completely in the following release but that's a discussion for another day, which will probably not happen until in 6 months time....
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister @rjmholt @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.