GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — move to new signing process for release build and prep for 1.20.0 by JamesWTruher · Pull Request #1625 · PowerShell/PSScriptAnalyzer

Conversation

James Truher (JamesWTruher) commented Jan 13, 2021

Copy link

Copy Markdown

Contributor

PR Summary

The infrastructure at MS has changed with regard to signing, this PR allows us to use it.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

James Truher (JamesWTruher) added the Area - Build label

Jan 13, 2021

James Truher (JamesWTruher) requested a review from Travis Plunk (TravisEz13)

January 13, 2021 17:08

James Truher (JamesWTruher) self-assigned this

Jan 13, 2021

Rob Holt (rjmholt) self-requested a review

January 13, 2021 19:15

Christoph Bergmeister (bergmeister) reviewed

Jan 14, 2021

View reviewed changes

Christoph Bergmeister (bergmeister) left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but the build seems to be broken. Also wondering whether 1.20.0 would be a better target version since the changes are all small improvements but not fixes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

James Truher (JamesWTruher) added 25 commits

February 10, 2021 10:35


          First cut at new release/signing build yml

150d81e


          remove display name from incorrect location


          change paths for changes in build system

232cb28


          add debugging info

21a029a


          Be sure to build all versions

daadefc


          change debugging code for 'Copy signed files'

1faf27b


          be sure to be in the correct location for creating the nupkg

d47c013


          Change nupkg building logic

fd6d5c2


          make not finding dotnet.exe a non fatal error for loading the module

57d4635


          fix path to suppression file

308f923


          debugging statements for compliance

2d1f8f4


          fix typo for credscan suppressions

5495b95

Add binskim scan directory


          Update to publish build directory

b535c72

Also publish nupkg directly from signed directory


          Be sure to publish the build directory

caf23fa

and don't publish the out directory, publishing the signed directory is enough


          published signed files need their own name

f9231e5


          add exception for README.md for cred scanner

91e0921

Fix up path for binskim


          try to get binskim to work with more direct path to assemblies

7fafc46


          debugging to find issues with signing files

484c051


          fix typo

8a6aeb2


          more debugging

0794d19


          remove debugging

39edbf6


          remove publish of nupkg

a55814b


          remove newtonsoft signing stage

275cbf2


          try the newton soft signing again

3dab1f9


          disable newtonsoft signing

29e870d

James Truher (JamesWTruher) added 7 commits

February 10, 2021 10:35


          try a 2 step process for signing

5e0a1de


          remove most of the debugging code

f0d5e1c

Also try to publish just the nupkg


          calculate version and publish nupkg

bb976f7


          fix 1 for module version

7f55032


          typo for module version

a66cb27


          Add a lot of comments to the yaml

2f1cf42


          suppress warnings for using PSRepository cmdlets

b6415c3

James Truher (JamesWTruher) force-pushed the releaseBuild002 branch from 5e9cb36 to b6415c3 Compare

February 10, 2021 18:36

James Truher (JamesWTruher) commented Feb 10, 2021

Copy link

Copy Markdown

Contributor Author

I've rebased to be up to date.

Christoph Bergmeister (@bergmeister), Rob Holt (@rjmholt), Sydney Smith (@SydneyhSmith) - Chris is suggesting that our next release should perhaps be number 1.20.0 and I wanted everyone to have a chance to provide an opinion. FWIW, I'm ok with 1.20

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Rob Holt (rjmholt) approved these changes

Feb 10, 2021

View reviewed changes

Rob Holt (rjmholt) left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- agree that 1.20 seems good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bergmeister and SydneyhSmith reacted with thumbs up emoji

All reactions

👍 2 reactions


          bump version to 1.20.0

43935ad

Travis Plunk (TravisEz13) reviewed

Feb 10, 2021

View reviewed changes

Travis Plunk (TravisEz13) left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks about right to me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Christoph Bergmeister (bergmeister) changed the title ~~move to new signing process for release build and prep for 1.19.2~~ move to new signing process for release build and prep for 1.20.0

Feb 10, 2021

Christoph Bergmeister (bergmeister) approved these changes

Feb 10, 2021

View reviewed changes


          change to use allowlist in documentation and tests

debd5fc

Rob Holt (rjmholt) approved these changes

Apr 21, 2021

View reviewed changes

Rob Holt (rjmholt) left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, just a small comment about the Write-Host invocations

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

.ci/releaseBuild.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update .ci/releaseBuild.yml

c0714ab

Co-authored-by: Robert Holt <[email protected]>

Rob Holt (rjmholt) reviewed

Apr 21, 2021

View reviewed changes

Comment thread

.ci/releaseBuild.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

.ci/releaseBuild.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

.ci/releaseBuild.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

.ci/releaseBuild.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Apply suggestions from code review

6edaba1

Rob Holt (rjmholt) merged commit 6bdc6f4 into PowerShell:master

Apr 22, 2021

Reviewers

Travis Plunk (TravisEz13)

TravisEz13 left review comments

Christoph Bergmeister (bergmeister)

bergmeister approved these changes

+1 more reviewer

Rob Holt (rjmholt)

rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

James Truher (JamesWTruher)

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

James Truher (JamesWTruher) commented Jan 13, 2021

PR Summary

PR Checklist

Uh oh!

Christoph Bergmeister (bergmeister) left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

James Truher (JamesWTruher) commented Feb 10, 2021

Uh oh!

Rob Holt (rjmholt) left a comment

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) left a comment

Choose a reason for hiding this comment

Uh oh!

Rob Holt (rjmholt) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Christoph Bergmeister (bergmeister) left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.