GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Speedup CI by bootstrapping PowerShell module installations in background and in parallel, whilst the .NET SDK is being installed by bergmeister · Pull Request #1634 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Jan 24, 2021

Copy link
Copy Markdown
Collaborator

PR Summary

Most of the time is spent bootstrapping the .NET SDK, meaning the installation of other required PowerShell modules can be done in the background and in parallel. This reduces the build time by around 20 seconds. Due to indentation shift, please use a white-space ignoring diff.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christoph Bergmeister (bergmeister) added 13 commits January 24, 2021 13:09
@bergmeister
Bootstrap dependencies in parallel in CI
6c84d23
@bergmeister
fix syntax
2556a3c
@bergmeister
fix function scope
5eceb86
@bergmeister
using for psscriptroot
c322aae
@bergmeister
add debugging statements
e64de8e
@bergmeister
add more logging and try fix wmf param ayntax
584e8f6
@bergmeister
try fix wmf syntax
f20bf3e
@bergmeister
try simplify
a3b4154
@bergmeister
set env outside psjob
8a52f3b
@bergmeister
only do psmodules as jobs
5ffd45a
@bergmeister
fix and shallow fetch
0d5f765
@bergmeister
shallow fetch for tests as well
32537f5
@bergmeister
undo shallow fetch as it made no difference
3fe37c6
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Build label Jan 24, 2021
@rjmholt
Rob Holt (rjmholt) requested a review from James Truher (JamesWTruher) April 21, 2021 20:42
@rjmholt

Rob Holt (rjmholt) commented Apr 21, 2021

Copy link
Copy Markdown
Contributor

James Truher (@JamesWTruher) need you to review this one
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rjmholt
Rob Holt (rjmholt) approved these changes Apr 21, 2021
View reviewed changes
@rjmholt
Rob Holt (rjmholt) merged commit 1ff493e into PowerShell:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.