GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add documentation around CustomRulePath in Settings file to README.md by johlju · Pull Request #1636 · PowerShell/PSScriptAnalyzer

Conversation

@johlju

@johlju Johan Ljunggren (johlju) commented Feb 2, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

  • Add documentation around CustomRulePath in Settings file to README.md

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

This change is Reviewable

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@johlju

Johan Ljunggren (johlju) commented Feb 2, 2021

Copy link
Copy Markdown
Contributor Author

Christoph Bergmeister (@bergmeister) as per request the updated docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@johlju
Add documentation CustomRulePath in README.md
93dbaed
@johlju
Johan Ljunggren (johlju) force-pushed the fix/readme-multiple-customrulepaths branch from e53fc60 to 93dbaed Compare February 2, 2021 12:27
@johlju

Johan Ljunggren (johlju) commented Feb 2, 2021

Copy link
Copy Markdown
Contributor Author

Not sure why the build is failing. Looks like pipeline is broken?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rjmholt
Rob Holt (rjmholt) approved these changes Feb 2, 2021
View reviewed changes
@bergmeister

Christoph Bergmeister (bergmeister) commented Feb 6, 2021

Copy link
Copy Markdown
Collaborator

Not sure why the build is failing. Looks like pipeline is broken?

It's a sporadic failure, for which I have PR #1632 to fix. I restarted the build, which worked this time.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Feb 6, 2021
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to write down your findings. Just one small suggestion please.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
johlju reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@johlju
Fix table of contents
2aa6d03
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Feb 7, 2021
View reviewed changes
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 820cde9 into PowerShell:master Feb 7, 2021
@johlju
Johan Ljunggren (johlju) deleted the fix/readme-multiple-customrulepaths branch February 7, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes
+1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@johlju @bergmeister @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.