GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Replace red-herring warning around process aliasing get-process with warning around invalid syntax by bergmeister · Pull Request #1638 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Feb 7, 2021

Copy link
Copy Markdown
Collaborator

PR Summary

Fixes #1402 by not warning around process aliasing get-process but rather that there is likely invalid syntax around the proces block since it is technically not possible to execute process as a command.

It would be better to have a rule of it's own for checking the begin/process/end blocks within a scriptblock but issue #1571 tracks this. This PR fixes the red-herring warning, whilst also giving a better warning to the user in the short term.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
andyleejordan reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bergmeister
Replace red-herring warning around process aliasing get-process with …
2da7bbd 
…warning around invalid syntax
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Rules label Feb 7, 2021
@SydneyhSmith Sydney Smith (SydneyhSmith) assigned Rob Holt (rjmholt) Apr 20, 2021
rjmholt
Rob Holt (rjmholt) approved these changes Apr 21, 2021
View reviewed changes
Comment thread Rules/Strings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.
@rjmholt
Update Rules/Strings.resx
0ecf7ee
@rjmholt
Rob Holt (rjmholt) merged commit 8a65e41 into PowerShell:master Apr 21, 2021
@ninmonkey Jake Bolton (ninmonkey) mentioned this pull request Sep 5, 2021
PSSA should have a new rule to check for properly used Process blocks #1571
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rjmholt Rob Holt (rjmholt)

Labels

Area - Rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'PROCESS' is implicitly aliasing 'Get-PROCESS'

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.