GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix BuildModules tests by clcaldwell · Pull Request #1654 · PowerShell/PSScriptAnalyzer

Conversation

@clcaldwell

@clcaldwell Coby Caldwell (clcaldwell) commented Mar 23, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Fixes #1653

Fix failing tests in BuildModules.tests.ps1 .
Move the tests into /Build/ in the central tests dir.
Add a reference to include the new folder path when executing all tests.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@clcaldwell
fixed build modules tests
7ed3b09
@clcaldwell
Coby Caldwell (clcaldwell) force-pushed the fix_build_module_tests branch from 6c91585 to 7ed3b09 Compare March 23, 2021 21:18
JamesWTruher
James Truher (JamesWTruher) approved these changes Mar 30, 2021
View reviewed changes

@JamesWTruher James Truher (JamesWTruher) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this, this seems to be fine. Interestingly, I wasn't getting any failures on MacOS. Can you let me know which platform was having the problem?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SydneyhSmith Sydney Smith (SydneyhSmith) assigned Rob Holt (rjmholt) Apr 20, 2021
rjmholt
Rob Holt (rjmholt) approved these changes Apr 21, 2021
View reviewed changes
@rjmholt
Rob Holt (rjmholt) merged commit 25b6548 into PowerShell:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rjmholt Rob Holt (rjmholt)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BuildModule.tests.ps1 Issues

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@clcaldwell @rjmholt @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.