GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Handle cases where the Signature generator fails catastrophically by JamesWTruher · Pull Request #1661 · PowerShell/PSScriptAnalyzer

Conversation

@JamesWTruher

@JamesWTruher James Truher (JamesWTruher) commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

PR Summary

In the profile collector, there are some cases when we attempt to generate a method signature the framework will generate a platform not supported exception which causes the profile generation to fail.

We're not yet shipping the collector as a standalone module (as we think we may change it in the future), but we would like the functionality to work correctly.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher
Changes needed to handle those cases where the Signature generator fa…
d25cc14 
…ils catastrophically
@JamesWTruher
James Truher (JamesWTruher) requested a review from Rob Holt (rjmholt) April 12, 2021 17:41
@JamesWTruher
add back beforeall for tests
4ad6788
rjmholt
Rob Holt (rjmholt) reviewed Apr 12, 2021
View reviewed changes
Comment thread ...mpatibilityCollector/Microsoft.PowerShell.CrossCompatibility/Collection/TypeDataCollector.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread ...mpatibilityCollector/Microsoft.PowerShell.CrossCompatibility/Collection/TypeDataCollector.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread ...mpatibilityCollector/Microsoft.PowerShell.CrossCompatibility/Collection/TypeDataCollector.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread ...mpatibilityCollector/Microsoft.PowerShell.CrossCompatibility/Collection/TypeDataCollector.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread ...mpatibilityCollector/Microsoft.PowerShell.CrossCompatibility/Collection/TypeDataCollector.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread ...mpatibilityCollector/Microsoft.PowerShell.CrossCompatibility/Collection/TypeDataCollector.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
James Truher (JamesWTruher) and others added 7 commits April 12, 2021 11:05
@JamesWTruher @rjmholt
Update PSCompatibilityCollector/Microsoft.PowerShell.CrossCompatibili…
9e5d741 
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <[email protected]>
@JamesWTruher @rjmholt
Update PSCompatibilityCollector/Microsoft.PowerShell.CrossCompatibili…
b07b947 
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <[email protected]>
@JamesWTruher @rjmholt
Update PSCompatibilityCollector/Microsoft.PowerShell.CrossCompatibili…
908d85e 
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <[email protected]>
@JamesWTruher @rjmholt
Update PSCompatibilityCollector/Microsoft.PowerShell.CrossCompatibili…
4ec4233 
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <[email protected]>
@JamesWTruher @rjmholt
Update PSCompatibilityCollector/Microsoft.PowerShell.CrossCompatibili…
b275b3a 
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <[email protected]>
@JamesWTruher @rjmholt
Update PSCompatibilityCollector/Microsoft.PowerShell.CrossCompatibili…
7a092a0 
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <[email protected]>
@JamesWTruher
MethodInfo should be MethodData
2b1332f
rjmholt
Rob Holt (rjmholt) approved these changes Apr 12, 2021
View reviewed changes
@SydneyhSmith Sydney Smith (SydneyhSmith) assigned Rob Holt (rjmholt) Apr 20, 2021
rjmholt
Rob Holt (rjmholt) approved these changes Apr 21, 2021
View reviewed changes
@rjmholt
Rob Holt (rjmholt) merged commit 6e95790 into PowerShell:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rjmholt Rob Holt (rjmholt)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JamesWTruher @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.