GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix compatibility rule tests by rjmholt · Pull Request #1697 · PowerShell/PSScriptAnalyzer

Conversation

@rjmholt

@rjmholt Rob Holt (rjmholt) commented Jul 14, 2021

Copy link
Copy Markdown
Contributor

PR Summary

Fixes #1695.

We've been seeing failures in the compatibility rule tests, such as in #1696. This seems to be due to a hashtable key being null, which would be explained by a Pester 5 semantics issue. This attempts to simplify the situation to fix the issue.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Rob Holt (rjmholt) added 3 commits July 14, 2021 10:07
@rjmholt
Fix compatibility rule tests
f3c0d4d
@rjmholt
Eliminate script scoped variables
772014b
@rjmholt
Move BeforeAll to within Describe
b03b451
@rjmholt Rob Holt (rjmholt) mentioned this pull request Jul 14, 2021
Script scope variables not defined for tests pester/Pester#2028
Closed
Rob Holt (rjmholt) added 3 commits July 14, 2021 11:32
@rjmholt
Update Pester installation code
9f4403f
@rjmholt
Fix dependency version reporting
e88ac4f
@rjmholt
Move some parts to discovery block and leave others
c7be234
@rjmholt
Rob Holt (rjmholt) force-pushed the fix-compatibility-tests branch from 3abfaf5 to c7be234 Compare July 14, 2021 19:09
Rob Holt (rjmholt) added 4 commits July 14, 2021 12:17
@rjmholt
Duplicate profile names
f8b8487
@rjmholt
Attempt to re-import Pester
c3632c6
@rjmholt
Get ipmo error now
e7f1c57
@rjmholt
Try to preserve Pester function
1f8f793
@rjmholt
Rob Holt (rjmholt) merged commit 00e0884 into PowerShell:master Jul 15, 2021
@rjmholt
Rob Holt (rjmholt) deleted the fix-compatibility-tests branch July 15, 2021 21:26
@rjmholt

Rob Holt (rjmholt) commented Jul 15, 2021

Copy link
Copy Markdown
Contributor Author

/cc t-lipingma
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rjmholt Rob Holt (rjmholt) mentioned this pull request Jul 15, 2021
test for pr checks #1696
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UseCompatibleTypes.Tests & UseCompatibleCommands.Tests test failed.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.