GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add metadata to docs by sdwheeler · Pull Request #1731 · PowerShell/PSScriptAnalyzer

Conversation

@sdwheeler

@sdwheeler Sean Wheeler (sdwheeler) commented Oct 18, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Fixes AB#1886304 - Fixes #1721 - Add metadata to docs

Added metadata needed for publishing to docs.microsoft.com, including an ms.custom value to track the version of PSSA. The description metadata value is taken from the CommonName property of the rule.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sdwheeler
Fixes PowerShell#1721 - Add metadata to docs
26dacc3
rjmholt
Rob Holt (rjmholt) reviewed Oct 18, 2021
View reviewed changes
Comment thread docs/Rules/UseSingularNouns.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Sean Wheeler (sdwheeler) added 2 commits October 18, 2021 13:33
@sdwheeler
Removed obsolete note
fffec54
@sdwheeler
more edits for docs compliance
534c9cc
@rjmholt
Rob Holt (rjmholt) enabled auto-merge (squash) October 18, 2021 21:56
@rjmholt Rob Holt (rjmholt) changed the title Fixes #1721 - Add metadata to docs Add metadata to docs Oct 18, 2021
@rjmholt
Rob Holt (rjmholt) disabled auto-merge October 19, 2021 19:38
@rjmholt
Rob Holt (rjmholt) merged commit 0be5a01 into PowerShell:master Oct 19, 2021
@sdwheeler
Sean Wheeler (sdwheeler) deleted the sdw-i1721 branch May 23, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add metadata to docs

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sdwheeler @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.