GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Broken link to list of approved verbs by antoniouaa · Pull Request #1734 · PowerShell/PSScriptAnalyzer

Conversation

@antoniouaa

@antoniouaa antoniouaa commented Oct 21, 2021

Copy link
Copy Markdown

The link was missing part of the URL that redirected to the MS docs.
From

/powershell/scripting/developer/cmdlet/approved-verbs-for-windows-powershell-commands

to

https://docs.microsoft.com/en-us/powershell/scripting/developer/cmdlet/approved-verbs-for-windows-powershell-commands

PR Summary

Fixes a broken link that 404's on GitHub but should direct to MS doc for Approved Verbs

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@antoniouaa
Broken link to list of approved verbs
17aceb2 
The link was missing part of the URL that redirected to the MS docs.
From
```
/powershell/scripting/developer/cmdlet/approved-verbs-for-windows-powershell-commands
```
to
```
https://docs.microsoft.com/en-us/powershell/scripting/developer/cmdlet/approved-verbs-for-windows-powershell-commands
```
@andyleejordan
Andy Jordan (andyleejordan) requested a review from Sean Wheeler (sdwheeler) October 25, 2021 23:15
@sdwheeler

Sean Wheeler (sdwheeler) commented Oct 25, 2021

Copy link
Copy Markdown
Contributor

Andy Jordan (@andschwa) The link is correct for the docs platform. It will be broken on GitHub but it is correct when published to the website. Please do not merge this PR.

See our contributor guide for more information: https://docs.microsoft.com/powershell/scripting/community/contributing/powershell-style-guide#hyperlinks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sdwheeler
Sean Wheeler (sdwheeler) suggested changes Oct 25, 2021
View reviewed changes

@sdwheeler Sean Wheeler (sdwheeler) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge this change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rjmholt

Rob Holt (rjmholt) commented Oct 26, 2021

Copy link
Copy Markdown
Contributor

James Truher (@JamesWTruher) Christoph Bergmeister (@bergmeister) we should discuss how we handle this issue in general
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@antoniouaa

antoniouaa commented Oct 26, 2021

Copy link
Copy Markdown
Author

Maybe you should add an alternative link then? This was my first stop when searching for a list of approved verbs and it probably is for a lot of other people.
andyleejordan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sdwheeler

Sean Wheeler (sdwheeler) commented Oct 26, 2021

Copy link
Copy Markdown
Contributor

This is source code, not documentation. You should be looking at the docs.microsoft.com site for documentation.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andyleejordan

Andy Jordan (andyleejordan) commented Oct 26, 2021

Copy link
Copy Markdown
Member

I think people are still going to look at the GitHub repo for documentation too, especially since that's where it's been hosted for years.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andyleejordan Andy Jordan (andyleejordan) mentioned this pull request Oct 28, 2021
Fix links to work on GitHub #1738
Merged
@bergmeister

Christoph Bergmeister (bergmeister) commented Mar 29, 2022

Copy link
Copy Markdown
Collaborator

Closing since PR #1738 superseded it. Please shout if that is not correct.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister Christoph Bergmeister (bergmeister) closed this Mar 29, 2022
@antoniouaa
antoniouaa deleted the patch-1 branch March 31, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sdwheeler Sean Wheeler (sdwheeler) sdwheeler requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@antoniouaa @sdwheeler @rjmholt @andyleejordan @bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.