GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Invoke-Formatter: Accept input from pipeline by bergmeister · Pull Request #1763 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Jan 19, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Implements #1761

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christoph Bergmeister (bergmeister) added 2 commits January 19, 2022 19:58
@bergmeister
Invoke-Formatter: Accept input from pipeline
434cacf
@bergmeister
other params as well
d647e4c
@bergmeister Christoph Bergmeister (bergmeister) changed the title Invoke-Formatter: Accept input from pipeline for main -ScriptDefinition parameter Invoke-Formatter: Accept input from pipeline Jan 19, 2022
@bergmeister
Merge branch 'PowerShell:master' into formatter/pipe
55605ca
@bergmeister Christoph Bergmeister (bergmeister) assigned James Truher (JamesWTruher) Jan 20, 2022
@kilasuit

Ryan Yates (kilasuit) commented Jan 20, 2022

Copy link
Copy Markdown
Contributor

LGTM Christoph Bergmeister (@bergmeister) :-)
bergmeister reacted with thumbs up emoji bergmeister reacted with laugh emoji bergmeister reacted with hooray emoji bergmeister reacted with heart emoji bergmeister reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 😄 1 reaction
  • 🎉 1 reaction
  • ❤️ 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Formatter label Jan 28, 2022
@bergmeister

Christoph Bergmeister (bergmeister) commented Jan 28, 2022

Copy link
Copy Markdown
Collaborator Author

Close and re-open so that Github removes the pending MacOs check which has been fixed/removed upstream in master
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister Christoph Bergmeister (bergmeister) closed this Jan 28, 2022
@bergmeister Christoph Bergmeister (bergmeister) reopened this Jan 28, 2022
@JamesWTruher James Truher (JamesWTruher) added this to the 1.21 milestone Jul 25, 2022
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Aug 11, 2022
Changelog for 1.21.0 #1828
Merged
5 of 6 tasks
JamesWTruher
James Truher (JamesWTruher) reviewed Aug 11, 2022
View reviewed changes
Comment thread Tests/Engine/InvokeFormatter.tests.ps1
'foo' | Invoke-Formatter | Should -Be 'foo'
}
It 'Value from Pipeline by Property Name with just the mandatory ScriptDefinition parameter' {
[pscustomobject]@{ 'ScriptDefinition' = 'foo' } | Invoke-Formatter | Should -Be 'foo'

@JamesWTruher James Truher (JamesWTruher) Aug 11, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[pscustomobject]@{ 'ScriptDefinition' = 'foo' } | Invoke-Formatter | Should -Be 'foo'
[pscustomobject]@{ 'ScriptDefinition' = 'command1;command2' } | Invoke-Formatter | Should -Be 'command1; command2'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JamesWTruher
James Truher (JamesWTruher) approved these changes Aug 11, 2022
View reviewed changes

@JamesWTruher James Truher (JamesWTruher) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine - just one suggestion below

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher
James Truher (JamesWTruher) merged commit d7a9fa8 into PowerShell:master Aug 11, 2022
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Aug 27, 2022
Fix 'Accept pipeline input' properties in documentation of Invoke-Formatter #1833
Merged
6 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JamesWTruher James Truher (JamesWTruher)

Labels

Area - Formatter

Projects

None yet

Milestone

1.21

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister @kilasuit @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.