GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Replicate changes from docs repo by sdwheeler · Pull Request #1781 · PowerShell/PSScriptAnalyzer

Conversation

@sdwheeler

@sdwheeler Sean Wheeler (sdwheeler) commented Mar 24, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Replicate changes from docs repo - see MicrosoftDocs/PowerShell-Docs-Modules#46

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sdwheeler
Sean Wheeler (sdwheeler) enabled auto-merge (squash) March 24, 2022 23:07
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Mar 29, 2022
View reviewed changes
@bergmeister

Christoph Bergmeister (bergmeister) commented Mar 29, 2022

Copy link
Copy Markdown
Collaborator

Sean Wheeler (@sdwheeler) If you pull in changes from master you should be able to fix to merge the PR as PR !1777 fixed this missing check.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sdwheeler
Replicate changes from docs repo
52e0b0f
@sdwheeler
Sean Wheeler (sdwheeler) force-pushed the sdw-i23 branch from 2211713 to 52e0b0f Compare March 29, 2022 19:32
@bergmeister

Christoph Bergmeister (bergmeister) commented Mar 29, 2022

Copy link
Copy Markdown
Collaborator

Hmm, seems that didn't work, I suggest to contact James Truher (@JamesWTruher) to get it merged as the left-over check doesn't seem to go away when pulling in master. It seems even for new PRs Github still wants to perform this old check that has already been removed in master
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JamesWTruher
James Truher (JamesWTruher) approved these changes Mar 29, 2022
View reviewed changes
@JamesWTruher
James Truher (JamesWTruher) disabled auto-merge March 29, 2022 20:17
@JamesWTruher
James Truher (JamesWTruher) merged commit 525a9c6 into PowerShell:master Mar 29, 2022
@sdwheeler
Sean Wheeler (sdwheeler) deleted the sdw-i23 branch May 23, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes
+1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sdwheeler @bergmeister @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.