GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Upgrade from net452 to net462 for Windows PowerShell by bergmeister · Pull Request #1789 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Apr 23, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Upgrading since older framework version will go out of support and and targeting a newer version will allow us to use more APIs. 4.6.2 is the older, still supported one
https://devblogs.microsoft.com/dotnet/net-framework-4-5-2-4-6-4-6-1-will-reach-end-of-support-on-april-26-2022/

As part of it I also fixed a bug that was introduced in PR #1425 where one line of code wasn't upgraded from PSV6 to PSV7

Furthermore APIs are being used that are in net462 but weren't available in net452

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christoph Bergmeister (bergmeister) added 2 commits April 23, 2022 16:10
@bergmeister
upgrade from net452 to net461 for windows ps
bb49427
@bergmeister
fix casing and bug where psv7 wasn't used
c3dd8a6
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Build label Apr 23, 2022
Christoph Bergmeister (bergmeister) added 3 commits April 23, 2022 22:18
@bergmeister
Merge branch 'master' of https://github.com/PowerShell/PSScriptAnalyzer…
9af64d7 
… into net462

# Conflicts:
#	README.md
@bergmeister
use APIs available in net461 but not net452
ae3f2bd
@bergmeister
Merge branch 'master' of https://github.com/PowerShell/PSScriptAnalyzer…
2b2883a 
… into net462

# Conflicts:
#	README.md
@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review May 27, 2022 16:22
Christoph Bergmeister (bergmeister) added 3 commits June 9, 2022 16:41
@bergmeister
Merge branch 'master' into net462
1bffaf7
@bergmeister
fix merge conflict error
00e1ce2
@bergmeister
empty
2646540
JamesWTruher
James Truher (JamesWTruher) approved these changes Jul 5, 2022
View reviewed changes

@JamesWTruher James Truher (JamesWTruher) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher
James Truher (JamesWTruher) merged commit b030262 into PowerShell:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.