GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Sync changes from docs repo by sdwheeler · Pull Request #1814 · PowerShell/PSScriptAnalyzer

Conversation

@sdwheeler

@sdwheeler Sean Wheeler (sdwheeler) commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

PR Summary

Copies the changes from PR MicrosoftDocs/PowerShell-Docs-Modules#74 that fixes issue MicrosoftDocs/PowerShell-Docs-Modules#17.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sdwheeler
Sync changes from docs repo
d31ba57
@sdwheeler
Sean Wheeler (sdwheeler) requested a review from Christoph Bergmeister (bergmeister) June 30, 2022 14:15
@sdwheeler

Sean Wheeler (sdwheeler) commented Jun 30, 2022

Copy link
Copy Markdown
Contributor Author

Christoph Bergmeister (@bergmeister) For your review
bergmeister reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Jun 30, 2022
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It's good we finally put the limitation around scriptblock scope into docs. I'm not sure folks will still understand it though what it means in terms of expected false positives. But this should not block this PR, I think I will take a note to add a couple of known false positives in another PR as it's a frequent source of opened issues (as well as user frustration)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sdwheeler Sean Wheeler (sdwheeler) added the Area - Documentation label Jun 30, 2022
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 323623d into PowerShell:master Jul 11, 2022
@sdwheeler
Sean Wheeler (sdwheeler) deleted the sdw-i17-UseVars branch December 7, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sdwheeler @bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.