GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Generate strongly typed resources as part of build by bergmeister · Pull Request #1855 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Oct 27, 2022

Copy link
Copy Markdown
Collaborator

PR Summary

At the moment one needs to update the Strings.Designer.cs files when new entries are adding to String.resx files because the .NET CLI cannot generate them by default, which makes it hard for developers that do not use Visual Studio but VS-Code or just CLI. However, there is a way to make this work and generate the strongly resource as part of the build and make it work for CLI, VS-Code (when it does a restore) and Visual Studio, which uses MSBuild, see here: dotnet/msbuild#4751

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christoph Bergmeister (bergmeister) added 3 commits October 27, 2022 11:08
@bergmeister
first working version
19f6561
@bergmeister
cleanup
7617a8e
@bergmeister
apply change to rules project as well
733b469
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Build label Oct 27, 2022
@bergmeister Christoph Bergmeister (bergmeister) changed the title Generate strongly typed resourced as part of build Generate strongly typed resources as part of build Oct 27, 2022
JamesWTruher
James Truher (JamesWTruher) approved these changes Sep 11, 2023
View reviewed changes

@JamesWTruher James Truher (JamesWTruher) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good - it's great that we don't need to do this manually.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher

James Truher (JamesWTruher) commented Sep 11, 2023

Copy link
Copy Markdown
Contributor

Christoph Bergmeister (@bergmeister) if you could solve the merge conflict that would be great.
bergmeister reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister
Merge branch 'master' of https://github.com/PowerShell/PSScriptAnalyzer…
7b8e7e4 
… into resgen

# Conflicts:
#	Rules/Strings.Designer.cs
@bergmeister

Christoph Bergmeister (bergmeister) commented Sep 17, 2023

Copy link
Copy Markdown
Collaborator Author

James Truher (@JamesWTruher) done. resolution was easy because this PR removes Strings.Designer.cs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister

Christoph Bergmeister (bergmeister) commented Jan 2, 2024

Copy link
Copy Markdown
Collaborator Author

Close and re-open to get latest CI check
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister Christoph Bergmeister (bergmeister) closed this Jan 2, 2024
@bergmeister Christoph Bergmeister (bergmeister) reopened this Jan 2, 2024
@JamesWTruher
James Truher (JamesWTruher) merged commit 847b146 into PowerShell:master Jan 16, 2024
This was referenced Mar 16, 2024
Update PSScriptAnalyzer to v1.22.0 ForNeVeR/intellij-powershell-fork#1
Closed
Update PSScriptAnalyzer to v1.22.0 intellij-powershell/intellij-powershell#244
Merged
Update PowerShellEditorServices to v3.18.1 and PSScriptAnalyzer to v1.22.0 ForNeVeR/intellij-powershell-fork#2
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.