GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bump Newtonsoft.Json to 13.0.3 by dependabot[bot] · Pull Request #1866 · PowerShell/PSScriptAnalyzer

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 24, 2022 •
edited by bergmeister
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Since oldest supported PS version 7.2.17 now uses 13.0.3 of Newtonsoft.Json, we can use the same version for Windows PS and PS 7. But leaving in separate paths as they could diverge again in future.
https://github.com/PowerShell/PowerShell/blob/b9fc8228a40634fde610887c404904f670eb2008/src/System.Management.Automation/System.Management.Automation.csproj#L15

Bumps Newtonsoft.Json from 12.0.3 to 13.0.2.

Release notes

Sourced from Newtonsoft.Json's releases.

13.0.2

  • New feature - Add support for DateOnly and TimeOnly
  • New feature - Add UnixDateTimeConverter.AllowPreEpoch property
  • New feature - Add copy constructor to JsonSerializerSettings
  • New feature - Add JsonCloneSettings to disable copy annotations
  • Change - Add nullable annotation to JToken.ToObject(Type, JsonSerializer)
  • Change - Reduced allocations by reusing boxed values
  • Fix - Fixed MaxDepth when used with ToObject inside of a JsonConverter
  • Fix - Fixed deserializing mismatched JToken types in properties
  • Fix - Fixed merging enumerable content and validate content
  • Fix - Fixed using $type with arrays of more than two dimensions
  • Fix - Fixed rare race condition in name table when deserializing on device with ARM processors
  • Fix - Fixed deserializing via constructor with ignored base type properties
  • Fix - Fixed MaxDepth not being used with ISerializable deserialization

13.0.1

  • New feature - Add JsonSelectSettings with configuration for a regex timeout
  • Change - Remove portable assemblies from NuGet package
  • Change - JsonReader and JsonSerializer MaxDepth defaults to 64
  • Change - Change InvalidCastException to JsonSerializationException on mismatched JToken
  • Fix - Fixed throwing missing member error on ignored fields
  • Fix - Fixed various nullable annotations
  • Fix - Fixed annotations not being copied when tokens are cloned
  • Fix - Fixed naming strategy not being used when deserializing dictionary enum keys
  • Fix - Fixed serializing nullable struct dictionaries
  • Fix - Fixed JsonWriter.WriteToken to allow null with string token
  • Fix - Fixed missing error when deserializing JToken with a contract type mismatch
  • Fix - Fixed JTokenWriter when writing comment to an object
Commits
  • 4fba53a Remove prerelease for 13.0.2
  • b15df4b Add missing headers
  • 789bfd3 Update to 13.0.2-beta3
  • b13717a Add JsonCloneSettings to disable copy annotations (#2757)
  • d0a328e Fix MaxDepth not being used with ISerializable deserialization (#2736)
  • aae9284 Update SDK
  • bd98970 Update to 13.0.2-beta2
  • 4dc9af6 Add roll forward to global.json (#2726)
  • b8f4ef0 Fixing misspelling (#2698)
  • cb9eed9 Fix deserializing via constructor with ignored base type properties (#2711)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@dependabot
Bump Newtonsoft.Json from 12.0.3 to 13.0.2
429c968
Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.3 to 13.0.2.
- [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases)
- [Commits](JamesNK/Newtonsoft.Json@12.0.3...13.0.2)

---
updated-dependencies:
- dependency-name: Newtonsoft.Json
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label Nov 24, 2022
@dependabot @github

dependabot Bot commented on behalf of github Nov 24, 2022

Copy link
Copy Markdown
Contributor Author

Dependabot tried to add @rjmholt, @JamesWTruher and @bergmeister as reviewers to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/PowerShell/PSScriptAnalyzer/pulls/1866/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the PowerShell/PSScriptAnalyzer repository. // See: https://docs.github.com/rest/reference/pulls#request-reviewers-for-a-pull-request
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bergmeister
Christoph Bergmeister (bergmeister) requested changes Nov 25, 2022
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not possible due to back compat

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bergmeister

Christoph Bergmeister (bergmeister) commented Dec 8, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Now that PowerShell 7.0 is out of support, we bump the version used by PowerShell Core to 13.0.1, which is the version used by the latest version of 7.2
https://github.com/PowerShell/PowerShell/blob/978d190594161a74c79e040eff3fdce8ddcff708/src/System.Management.Automation/System.Management.Automation.csproj#LL15C8-L15C8

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Dec 8, 2022
Bump Newtonsoft.Json from 12.0.3 to 13.0.2 in /Rules #1870
Closed
Bump Newtonsoft.Json from 12.0.3 to 13.0.2 in /PSCompatibilityCollector/Microsoft.PowerShell.CrossCompatibility #1871
Closed
bergmeister
Christoph Bergmeister (bergmeister) reviewed Dec 8, 2022
View reviewed changes
Comment thread ...ector/Microsoft.PowerShell.CrossCompatibility/Microsoft.PowerShell.CrossCompatibility.csproj Resolved

Uh oh!

There was an error while loading. Please reload this page.

bergmeister
Christoph Bergmeister (bergmeister) reviewed Dec 8, 2022
View reviewed changes
Comment thread Rules/Rules.csproj Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister
Apply suggestions from code review
a3555a4
@bergmeister Christoph Bergmeister (bergmeister) changed the title Bump Newtonsoft.Json from 12.0.3 to 13.0.2 Bump Newtonsoft.Json from 12.0.3 to 13.0.2 for Windows PowerShell and 13.0.1 for PowerShell 7.x Dec 8, 2022
@fflaten Frode Flaten (fflaten) mentioned this pull request Feb 28, 2023
Update dependabot reviewers to remove Rob #1897
Merged
5 of 6 tasks
@dependabot @github

dependabot Bot commented on behalf of github Mar 8, 2023

Copy link
Copy Markdown
Contributor Author

A newer version of Newtonsoft.Json exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bergmeister
Christoph Bergmeister (bergmeister) reviewed Jan 2, 2024
View reviewed changes
Comment thread ...ector/Microsoft.PowerShell.CrossCompatibility/Microsoft.PowerShell.CrossCompatibility.csproj Resolved

Uh oh!

There was an error while loading. Please reload this page.

bergmeister
Christoph Bergmeister (bergmeister) reviewed Jan 2, 2024
View reviewed changes
Comment thread ...ector/Microsoft.PowerShell.CrossCompatibility/Microsoft.PowerShell.CrossCompatibility.csproj Resolved

Uh oh!

There was an error while loading. Please reload this page.

bergmeister
Christoph Bergmeister (bergmeister) reviewed Jan 2, 2024
View reviewed changes
Comment thread Rules/Rules.csproj Resolved

Uh oh!

There was an error while loading. Please reload this page.

bergmeister
Christoph Bergmeister (bergmeister) reviewed Jan 2, 2024
View reviewed changes
Comment thread Rules/Rules.csproj Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister
Bump all version to 13.0.3
3efd783
@bergmeister Christoph Bergmeister (bergmeister) changed the title Bump Newtonsoft.Json from 12.0.3 to 13.0.2 for Windows PowerShell and 13.0.1 for PowerShell 7.x Bump Newtonsoft.Json to 13.0.3 Jan 2, 2024
@bergmeister

Christoph Bergmeister (bergmeister) commented Jan 2, 2024

Copy link
Copy Markdown
Collaborator

Now latest 7.2 version also uses latest Newtonsoft version so bumped the version

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister Christoph Bergmeister (bergmeister) added the Area - Build label Jan 2, 2024
bergmeister
Christoph Bergmeister (bergmeister) reviewed Jan 2, 2024
View reviewed changes
Comment thread ...ector/Microsoft.PowerShell.CrossCompatibility/Microsoft.PowerShell.CrossCompatibility.csproj Resolved

Uh oh!

There was an error while loading. Please reload this page.

bergmeister
Christoph Bergmeister (bergmeister) reviewed Jan 2, 2024
View reviewed changes
Comment thread Rules/Rules.csproj Resolved

Uh oh!

There was an error while loading. Please reload this page.

Christoph Bergmeister (bergmeister) added 2 commits January 2, 2024 14:37
@bergmeister
Apply suggestions from code review
229ca24
@bergmeister
Merge branch 'master' into dependabot/nuget/Newtonsoft.Json-13.0.2
3e9df8c
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Jan 18, 2024
View reviewed changes
@JamesWTruher
James Truher (JamesWTruher) merged commit 2245064 into master Jan 18, 2024
@dependabot
dependabot Bot deleted the dependabot/nuget/Newtonsoft.Json-13.0.2 branch January 18, 2024 18:44
This was referenced Mar 16, 2024
Update PSScriptAnalyzer to v1.22.0 ForNeVeR/intellij-powershell-fork#1
Closed
Update PSScriptAnalyzer to v1.22.0 intellij-powershell/intellij-powershell#244
Merged
@github-actions github-actions Bot mentioned this pull request Mar 20, 2024
Update PowerShellEditorServices to v3.18.1 and PSScriptAnalyzer to v1.22.0 ForNeVeR/intellij-powershell-fork#2
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.