GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Upgrade to use .NET 6 since PowerShell 7.0 is now out out of support by bergmeister · Pull Request #1873 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Dec 8, 2022 •
edited by SydneyhSmith
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Only PowerShell 7.2 and 7.3 are supported at the moment, which are using .NET 6 and 7, therefore we can bump our version of .NET as well.

fixes #1919

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister
Upgrade to use .NET 6
bffbb36
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Build label Dec 8, 2022
@fflaten

Frode Flaten (fflaten) commented Feb 27, 2023

Copy link
Copy Markdown
Contributor

Remember to bump devcontainer-image as well :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request May 25, 2023
.NET SDK 3 is end of life (eol) - move to 6 or 7 #1919
Closed
@peterhoeg

Peter Hoeg (peterhoeg) commented May 26, 2023

Copy link
Copy Markdown

Doesn't this need to change too:

PSScriptAnalyzer/PSCompatibilityCollector/Microsoft.PowerShell.CrossCompatibility/Microsoft.PowerShell.CrossCompatibility.csproj

Line 5 in 9f456d0

<TargetFrameworks>netstandard2.0;net462</TargetFrameworks>

?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JamesWTruher
James Truher (JamesWTruher) approved these changes Aug 21, 2023
View reviewed changes

@JamesWTruher James Truher (JamesWTruher) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister

Christoph Bergmeister (bergmeister) commented Sep 17, 2023

Copy link
Copy Markdown
Collaborator Author

Doesn't this need to change too:

PSScriptAnalyzer/PSCompatibilityCollector/Microsoft.PowerShell.CrossCompatibility/Microsoft.PowerShell.CrossCompatibility.csproj

Line 5 in 9f456d0

<TargetFrameworks>netstandard2.0;net462</TargetFrameworks>

?

No, net 462 is for windows powershell and .net 6 still implements .net standard 2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 772997f into PowerShell:master Sep 17, 2023
This was referenced Mar 16, 2024
Update PSScriptAnalyzer to v1.22.0 ForNeVeR/intellij-powershell-fork#1
Closed
Update PSScriptAnalyzer to v1.22.0 intellij-powershell/intellij-powershell#244
Merged
Update PowerShellEditorServices to v3.18.1 and PSScriptAnalyzer to v1.22.0 ForNeVeR/intellij-powershell-fork#2
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.NET SDK 3 is end of life (eol) - move to 6 or 7

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@bergmeister @fflaten @peterhoeg @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.