GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make Settings type detection more robust by Tadas · Pull Request #1967 · PowerShell/PSScriptAnalyzer

Conversation

@Tadas

@Tadas Tadas Medišauskas (Tadas) commented Feb 16, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

It was unable to parse settings hashtable, when that hashtable has been wrapped as a PSObject. This started happening in PS 7.2, I was using Import-PowerShellDataFile to read some settings before passing them on to Invoke-ScriptAnalyzer.

There was some code to handle wrapped strings, might as well do that with all parameter types.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Tadas

Tadas Medišauskas (Tadas) commented Feb 16, 2024

Copy link
Copy Markdown
Contributor Author

Related to #807 but that particular scenario was being covered.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister
Christoph Bergmeister (bergmeister) requested review from Andy Jordan (andyleejordan) and Christoph Bergmeister (bergmeister) as code owners February 17, 2025 21:00
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Feb 17, 2025
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry for late review. Kicked off CI and pending that all good.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Tadas @andyleejordan
Add PSObject unwrapping for all Settings types
16f6601
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the master branch from 591c051 to 16f6601 Compare February 19, 2025 22:25
andyleejordan
Andy Jordan (andyleejordan) suggested changes Feb 20, 2025
View reviewed changes
Comment thread Engine/Settings.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@andyleejordan
Update Engine/Settings.cs
26d38cc
andyleejordan
Andy Jordan (andyleejordan) approved these changes Feb 20, 2025
View reviewed changes

@andyleejordan Andy Jordan (andyleejordan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully the tests still pass because I didn't test that myself!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andyleejordan
Andy Jordan (andyleejordan) enabled auto-merge (squash) February 20, 2025 22:49
@andyleejordan
Andy Jordan (andyleejordan) merged commit dc4ae4b into PowerShell:main Feb 20, 2025
@Tadas Tadas Medišauskas (Tadas) mentioned this pull request Sep 4, 2025
Unable to run rules with hashtable that run fine with settings file #2047
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes
+1 more reviewer
@andyleejordan Andy Jordan (andyleejordan) andyleejordan approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Tadas @andyleejordan @bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.