GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Adding OneBranch pipeline YAML config file for OSS_Microsoft_PSSA-Official by adityapatwardhan · Pull Request #1981 · PowerShell/PSScriptAnalyzer

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Mar 11, 2024

Copy link
Copy Markdown
Member

PR Summary

Onboarding to OneBranch pipelines

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
OneBranch Resources @adityapatwardhan
Adding OneBranch pipeline YAML config file for OSS_Microsoft_PSSA-Off…
0cb2a22 
…icial
TravisEz13
Travis Plunk (TravisEz13) reviewed Mar 12, 2024
View reviewed changes
Comment thread .config/tsaoptions.json Outdated
{
"instanceUrl": "https://msazure.visualstudio.com",
"projectName": "One",
"areaPath": "One\\MGMT\\Compute\\Powershell\\Powershell",

@TravisEz13 Travis Plunk (TravisEz13) Mar 12, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the PowerShell Core subpath, see

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
TravisEz13
Travis Plunk (TravisEz13) reviewed Mar 12, 2024
View reviewed changes
Comment thread .pipelines/OSS_Microsoft_PSSA-Official.yml
- checkout: self
- checkout: ComplianceRepo

- pwsh: |

@TravisEz13 Travis Plunk (TravisEz13) Mar 12, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add display names for tasks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Mar 12, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is there below.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Aditya Patwardhan (adityapatwardhan) added 7 commits March 12, 2024 11:05
@adityapatwardhan
Updates to signing and TSA
9fa47ae
@adityapatwardhan
Fix typo
23956e7
@adityapatwardhan
Fix typo 2
19bca77
@adityapatwardhan
Fix typo 3
0a887a3
@adityapatwardhan
Update CR feedback
3954ca5
@adityapatwardhan
Revert back to old signing
2f56f2c
@adityapatwardhan
Fix source direcctory for credscan
c0f7819
TravisEz13
Travis Plunk (TravisEz13) approved these changes Mar 13, 2024
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Mar 13, 2024

Copy link
Copy Markdown
Member

Signing needs to be improved, but I'll open a second PR to do that and fix some fit and finish.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JamesWTruher
James Truher (JamesWTruher) self-requested a review March 13, 2024 17:06
JamesWTruher
James Truher (JamesWTruher) approved these changes Mar 13, 2024
View reviewed changes
@JamesWTruher
James Truher (JamesWTruher) merged commit b4365ad into PowerShell:master Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
+1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@adityapatwardhan @TravisEz13 @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.