GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Move to OneBranch Signing and SBOM generation by TravisEz13 · Pull Request #1982 · PowerShell/PSScriptAnalyzer

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Mar 14, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

  • Move to OneBranch Pipelines (OBP) signing
  • Move to OBP SBOM generation
    • Fix issues with SBOM generation (missing name and version)
  • Move to newest OBP container
  • Add nupkg signing (future use)

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Aditya Patwardhan (adityapatwardhan) and others added 30 commits March 13, 2024 10:44
@adityapatwardhan @TravisEz13
Updates to signing
1ed48b1
@TravisEz13
fix files to sign
b74f202
@TravisEz13
sbom changes
9a24c68
@TravisEz13
format changes
b9cdd49
@TravisEz13
Make packaging wait on build
83cc690
@TravisEz13
clarify task display names
ed91b82
@TravisEz13
Make sure signing is setup
80473e2
@TravisEz13
move other tasks to restore phase
18232e3
@TravisEz13
move checkout to restore phase
a570c56
@TravisEz13
update container
4331d7b
@TravisEz13
move signing to it's own job
473498e
@TravisEz13
add flag required for newest container
4330f12
@TravisEz13
clarify copy files task displaynames
1bdc123
@TravisEz13
reuse existing variable
3d2c9dd
@TravisEz13
removed unneeded code
a9cadb3
@TravisEz13
Use correct path is signing job
dd9e7a6
@TravisEz13
sign the nupkg
5062efd
@TravisEz13
fix syntax
1465ca9
@TravisEz13
Revert "clarify copy files task displaynames"
fa48f5d 
This reverts commit 1bdc123.
@TravisEz13
Disable code sign validation on first job
9c1cfad
@TravisEz13
search for where OBP put dotnet.exe
d5d03f0
@TravisEz13
Move SDK search to it's own job
f3ef9e7
@TravisEz13
delete SDK search
ac44341
@TravisEz13
make nupkg signing a todo
440ceb6
@TravisEz13
fix nupkg publishing
9c65c5b
@TravisEz13
try disabling codeql to get signing working per docs
663f093
@TravisEz13
don't setup signing where not needed
1ed8039
@TravisEz13
combine sign and build job
a03237d
@TravisEz13
set version for SBOM
504c5df
@TravisEz13
make comments more accurate
dd8c136
TravisEz13
Travis Plunk (TravisEz13) commented Mar 14, 2024
View reviewed changes
Comment thread .pipelines/OSS_Microsoft_PSSA-Official.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) commented Mar 14, 2024
View reviewed changes
Comment thread .pipelines/OSS_Microsoft_PSSA-Official.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) commented Mar 14, 2024
View reviewed changes
Comment thread .pipelines/OSS_Microsoft_PSSA-Official.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) commented Mar 14, 2024
View reviewed changes
Comment thread .pipelines/OSS_Microsoft_PSSA-Official.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) commented Mar 14, 2024
View reviewed changes
Comment thread .pipelines/OSS_Microsoft_PSSA-Official.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Travis Plunk (TravisEz13) and others added 2 commits March 14, 2024 09:09
@TravisEz13
Apply suggestions from code review
9a68ea5
@TravisEz13
fix variable name
49d6365
JamesWTruher
James Truher (JamesWTruher) reviewed Mar 14, 2024
View reviewed changes
Comment thread .pipelines/OSS_Microsoft_PSSA-Official.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
address pr comments
368a7e8
JamesWTruher
James Truher (JamesWTruher) approved these changes Mar 14, 2024
View reviewed changes
@JamesWTruher
James Truher (JamesWTruher) merged commit 62a14c5 into PowerShell:master Mar 14, 2024
@TravisEz13
Travis Plunk (TravisEz13) deleted the CodeSigning branch March 14, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@TravisEz13 @JamesWTruher @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.