GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — PSAlignAssignmentStatement: Ignore hashtables with a single key-value pair by liamjpeters · Pull Request #1986 · PowerShell/PSScriptAnalyzer

Conversation

@liamjpeters

@liamjpeters Liam Peters (liamjpeters) commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

PR Summary

Hashtables with a single key-value pair should be ignored by PSAlignAssignmentStatement as there is nothing to align.

There are other rules that handle whitespace around operators etc which can handle formatting according to the users preference.

Currently:

Invoke-Formatter -ScriptDefinition "@{'Key'='Value'}" -Settings @{
    Rules = @{
        PSAlignAssignmentStatement = @{
            Enable = $true
            CheckHashtable = $true
        }
    }
}

Results in:

@{'Key' ='Value'}

Note the space added after the hashtable key

Resolves #1979

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

o-l-a-v reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@liamjpeters

Liam Peters (liamjpeters) commented Mar 27, 2024

Copy link
Copy Markdown
Contributor Author

My git-foo is not strong so this is a re-raise of #1983 where the full test checks were completed and passed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@liamjpeters Liam Peters (liamjpeters) mentioned this pull request Apr 9, 2024
PSAlignAssignmentStatement: Ignore hashtables with a single key-value pair #1983
Closed
6 tasks done
@bergmeister
Christoph Bergmeister (bergmeister) requested review from Andy Jordan (andyleejordan) and Christoph Bergmeister (bergmeister) as code owners February 17, 2025 21:00
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Feb 17, 2025
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to fix this undesired side effect in this case. the formatting rules have so many special oddities 😅

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

liamjpeters reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
andyleejordan
Andy Jordan (andyleejordan) approved these changes Feb 19, 2025
View reviewed changes

@andyleejordan Andy Jordan (andyleejordan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@andyleejordan
Andy Jordan (andyleejordan) enabled auto-merge (squash) February 19, 2025 18:24
@liamjpeters @andyleejordan
Rules>PSAlignAssignmentStatement: Treat single kvp hashtables as bein…
d831fba
…g on a single line, and not checked for violations.
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the #1979IgnoreHashtablesWithASingleKVP branch from 57cb24b to d831fba Compare February 19, 2025 18:28
@andyleejordan
Andy Jordan (andyleejordan) merged commit 20135fb into PowerShell:main Feb 19, 2025
@liamjpeters
Liam Peters (liamjpeters) deleted the #1979IgnoreHashtablesWithASingleKVP branch February 21, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes
+1 more reviewer
@andyleejordan Andy Jordan (andyleejordan) andyleejordan approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adds whitespace around operators with whitespaceAroundOperator set to false in some cases

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@liamjpeters @andyleejordan @bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.