GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update default type definition of `RuleInfo` by liamjpeters · Pull Request #2011 · PowerShell/PSScriptAnalyzer

Conversation

@liamjpeters

@liamjpeters Liam Peters (liamjpeters) commented Jul 8, 2024

Copy link
Copy Markdown
Contributor

PR Summary

The default type definition of [Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.RuleInfo] declares a property called Name - which is not a member of the type.

PR updates this to RuleName.

Resolves #2010

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

SydneyhSmith reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@liamjpeters
Update default type definition of [Microsoft.Windows.PowerShell.Scrip…
16ecc4f
…tAnalyzer.Generic.RuleInfo]
SydneyhSmith
Sydney Smith (SydneyhSmith) approved these changes Jul 16, 2024
View reviewed changes
@SydneyhSmith
Sydney Smith (SydneyhSmith) merged commit b5fec0a into PowerShell:master Jul 16, 2024
@liamjpeters
Liam Peters (liamjpeters) deleted the #2010ListViewNameProperty branch August 7, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SydneyhSmith Sydney Smith (SydneyhSmith) SydneyhSmith approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Get-ScriptAnalyzerRule default list view shows no value for property "Name"

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@liamjpeters @SydneyhSmith
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.