GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Setup new OneBranch pipeline by andyleejordan · Pull Request #2027 · PowerShell/PSScriptAnalyzer

Conversation

@andyleejordan

@andyleejordan Andy Jordan (andyleejordan) commented Sep 11, 2024

Copy link
Copy Markdown
Member

And some overdue clean-ups.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andy Jordan (andyleejordan) added 3 commits September 10, 2024 12:25
@andyleejordan
Delete deprecated files
28ee69a 
* Azure Pipelines
* Docker containers
* AppVeyor
* ESRP
@andyleejordan
Small updates
57ae6e0 
* Slight .NET SDK bump to satisfy Component Governance
* Update license with OSPO's preferred format
* Add self to TSA notification list
* Remove containers VS Code extension suggestion
@andyleejordan
Remove dotnet bootstrap/installation code
08c24ea 
We should not be doing this for the developer/user.
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the test/onebranch branch from d734de7 to 64a7ed0 Compare September 11, 2024 00:19
@andyleejordan

Andy Jordan (andyleejordan) commented Sep 11, 2024

Copy link
Copy Markdown
Member Author

Hey Christoph Bergmeister (@bergmeister) are you still using the Docker containers? I assumed not as they hadn't been updated in years.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Andy Jordan (andyleejordan) added 2 commits September 10, 2024 18:03
@andyleejordan
Setup OneBranch and package build
9a00d23
@andyleejordan
Fix unit tests for PowerShell 7.4
5637f39 
Which now comes with PSResourceGet
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the test/onebranch branch from 4290fe2 to 5637f39 Compare September 11, 2024 01:03
@andyleejordan
Andy Jordan (andyleejordan) marked this pull request as ready for review September 11, 2024 17:41
@andyleejordan
Andy Jordan (andyleejordan) requested a review from James Truher (JamesWTruher) September 11, 2024 21:24
JamesWTruher
James Truher (JamesWTruher) approved these changes Sep 11, 2024
View reviewed changes

@JamesWTruher James Truher (JamesWTruher) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!
this looks great to me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andyleejordan
Andy Jordan (andyleejordan) merged commit f7304c7 into main Sep 11, 2024
@andyleejordan
Andy Jordan (andyleejordan) deleted the test/onebranch branch September 11, 2024 22:49
@bergmeister

Christoph Bergmeister (bergmeister) commented Sep 16, 2024

Copy link
Copy Markdown
Collaborator

Hey Christoph Bergmeister (@bergmeister) are you still using the Docker containers? I assumed not as they hadn't been updated in years.

Andy Jordan (@andyleejordan) Sorry for the late reply. Yes, I find them very useful. The only thing that needs updating is the .NET version, which doesn't happen very often due to having support older PS versions. I've been busy generally but plan to look at new issues and pull requests again soon
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bergmeister
Christoph Bergmeister (bergmeister) reviewed Sep 16, 2024
View reviewed changes
Comment thread appveyor.yml

@bergmeister Christoph Bergmeister (bergmeister) Sep 16, 2024

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Andy Jordan (@andyleejordan) Although we are not running Appveyor in CI any more, I am still running it in my fork to check that PowerShell 4 build and test still works (hence why appveyor.psm1 was kept as well)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bergmeister
Christoph Bergmeister (bergmeister) reviewed Sep 16, 2024
View reviewed changes
Comment thread .github/workflows/ci-test.yml
@@ -45,6 +49,13 @@ jobs:
if: matrix.os == 'windows-latest'

@bergmeister Christoph Bergmeister (bergmeister) Sep 16, 2024

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add another 'OS' in the matrix so that there is one windows run for powershell core and one for windows powershell so that it can finisher quicker.
What we've lost with this test approach is that the test job used to be its own job just consuming the binary as artefacts (and the repo checkout because of test files although they should've technically also been an artefact). This ensured that the built binaries were sufficient and weren't relying on something else left lying around from the build

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister left review comments
+1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@andyleejordan @bergmeister @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.