GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bump SMA version by andyleejordan · Pull Request #2028 · PowerShell/PSScriptAnalyzer

Conversation

@andyleejordan

@andyleejordan Andy Jordan (andyleejordan) commented Sep 17, 2024

Copy link
Copy Markdown
Member

See title.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andyleejordan
Bump SMA version
0808f8a
SydneyhSmith
Sydney Smith (SydneyhSmith) approved these changes Sep 17, 2024
View reviewed changes
@andyleejordan
Andy Jordan (andyleejordan) merged commit 4002b3c into main Sep 17, 2024
@andyleejordan
Andy Jordan (andyleejordan) deleted the update-sma branch September 17, 2024 20:26
bergmeister
Christoph Bergmeister (bergmeister) reviewed Sep 17, 2024
View reviewed changes
Comment thread Engine/Engine.csproj

<ItemGroup Condition="'$(TargetFramework)' == 'net6'">
<PackageReference Include="System.Management.Automation" Version="7.0.11" />
<PackageReference Include="System.Management.Automation" Version="7.0.13" />

@bergmeister Christoph Bergmeister (bergmeister) Sep 17, 2024

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Andy Jordan (@andyleejordan) Why not 7.2.23? I believe 7.0.x was from days where we still had to support PowerShell 7.0. Now it's just 7.2 and after November 8, it will be just 7.4 (which will also mean we will be able to bump .NET version to 8) https://learn.microsoft.com/en-us/powershell/scripting/install/powershell-support-lifecycle?view=powershell-7.4#powershell-end-of-support-dates

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@andyleejordan Andy Jordan (andyleejordan) Sep 17, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah fair but we should do that for a point release, not a patch release.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@andyleejordan Andy Jordan (andyleejordan) Sep 25, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So Christoph Bergmeister (@bergmeister) I actually have to circle back and do this now 😅

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister left review comments
@SydneyhSmith Sydney Smith (SydneyhSmith) SydneyhSmith approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@andyleejordan @bergmeister @SydneyhSmith
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.