GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Invoke-ScriptAnalyzer: Print summary only once per invocation by MatejKafka · Pull Request #2063 · PowerShell/PSScriptAnalyzer

Conversation

@MatejKafka

@MatejKafka Matěj Kafka (MatejKafka) commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

PR Summary

Similarly to the previous -EnableExit PR, this PR moves the summary printed when -ReportSummary is passed to EndProcessing, so that it's only printed once, instead of once for every value from the pipeline.

Imo, users are likely to be interested in the summary from all of the piped files, not for each file separately. Since the message is printed to the host (so the caller has no easy way to capture it), I don't believe moving it to be a breaking change.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MatejKafka
Matěj Kafka (MatejKafka) requested review from Andy Jordan (andyleejordan) and Christoph Bergmeister (bergmeister) as code owners February 21, 2025 14:09
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the single-summary-pipeline branch from ed43569 to cc57fa5 Compare February 25, 2025 00:16
andyleejordan
Andy Jordan (andyleejordan) approved these changes Feb 25, 2025
View reviewed changes

@andyleejordan Andy Jordan (andyleejordan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good refactor to me, thanks! Gotta love dictionaries.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
andyleejordan
Andy Jordan (andyleejordan) reviewed Feb 25, 2025
View reviewed changes
Comment thread Engine/Commands/InvokeScriptAnalyzerCommand.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@MatejKafka
Invoke-ScriptAnalyzer: Print summary only once per invocation
55d50d0
@MatejKafka
Matěj Kafka (MatejKafka) force-pushed the single-summary-pipeline branch from cc57fa5 to 55d50d0 Compare February 26, 2025 23:55
@andyleejordan
Andy Jordan (andyleejordan) merged commit bcec9f6 into PowerShell:main Feb 28, 2025
@MatejKafka
Matěj Kafka (MatejKafka) deleted the single-summary-pipeline branch March 1, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) Awaiting requested review from bergmeister bergmeister is a code owner
1 more reviewer
@andyleejordan Andy Jordan (andyleejordan) andyleejordan approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@MatejKafka @andyleejordan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.