GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — PSUseConsistentWhitespace: Correctly fix whitespace between command parameters when parameter value spans multiple lines by liamjpeters · Pull Request #2064 · PowerShell/PSScriptAnalyzer Conversation
Contributor
PR SummaryChanges the suggested correction extent of When enabled, the An erroneous correction extent was being generated when parameter values spanned multiple lines (such as for arrays, scriptblocks, and hashtables. For instance, using the below settings to isolate only the $Settings = @{ IncludeRules = @('PSUseConsistentWhitespace') Rules = @{ PSUseConsistentWhitespace = @{ Enable = $true CheckInnerBrace = $false CheckOpenBrace = $false CheckOpenParen = $false CheckOperator = $false CheckPipe = $false CheckPipeForRedundantWhitespace = $false CheckSeparator = $false CheckParameter = $true IgnoreAssignmentOperatorInsideHashTable = $false } } } Running the formatter against: foo {
bar
} -baz
foo @{
1 = 1
} -baz
foo @(
1
) -baz
Resulted in: fo-baz fo-baz fo-baz Fixes #2060 PR Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Liam Peters (liamjpeters)
requested review from
Andy Jordan (andyleejordan) and
Christoph Bergmeister (bergmeister)
as code owners
…the correction should begin on the last line of the left extent and end on the first line of the right extent
Andy Jordan (andyleejordan)
force-pushed
the
#2060WhiteSpaceBetweenParametersIssue
branch
from
ad83312 to
78de299
Compare
Andy Jordan (andyleejordan)
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice fix, thank you.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Andy Jordan (andyleejordan)
enabled auto-merge (squash)
Liam Peters (liamjpeters)
deleted the
#2060WhiteSpaceBetweenParametersIssue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers1 more reviewerUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Unexpected string with powershell.codeFormatting.whitespaceBetweenParameters enabledUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |