GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Invoke-ScriptAnalyzer: Include parse errors in reported error count by MatejKafka · Pull Request #2069 · PowerShell/PSScriptAnalyzer

Conversation

@MatejKafka

@MatejKafka Matěj Kafka (MatejKafka) commented Mar 1, 2025

Copy link
Copy Markdown
Contributor

PR Summary

Previously, parse error were not reported in the summary. With this PR, the exit code from -EnableExit matches the number of diagnostics reported by -ReportSummary and parse errors are included under errors. Since -ReportSummary output is sent directly to the host, I don't believe this to be a breaking change.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • [-] Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MatejKafka
Matěj Kafka (MatejKafka) requested review from Andy Jordan (andyleejordan) and Christoph Bergmeister (bergmeister) as code owners March 1, 2025 02:17
andyleejordan
Andy Jordan (andyleejordan) reviewed Mar 1, 2025
View reviewed changes
Comment thread Engine/Commands/InvokeScriptAnalyzerCommand.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
andyleejordan
Andy Jordan (andyleejordan) approved these changes Mar 13, 2025
View reviewed changes
@andyleejordan
Andy Jordan (andyleejordan) enabled auto-merge (squash) March 13, 2025 16:28
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the report-summary-parse-errors branch from d6d1f36 to 3390d78 Compare March 13, 2025 16:54
@MatejKafka @andyleejordan
Invoke-ScriptAnalyzer: Include parse errors in reported error count
38f2c98 
Previously, parse error were not reported in the summary. With this commit,
the exit code from -EnableExit matches the number of reported issues.
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the report-summary-parse-errors branch from 3390d78 to 38f2c98 Compare March 13, 2025 17:58
@andyleejordan
Andy Jordan (andyleejordan) merged commit 8862e51 into PowerShell:main Mar 13, 2025
@coderabbitai coderabbitai Bot mentioned this pull request Aug 2, 2026
chore: adopt shared lefthook hooks and PR template Jmeg8r/mcp-astgl-knowledge#51
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) Awaiting requested review from bergmeister bergmeister is a code owner
1 more reviewer
@andyleejordan Andy Jordan (andyleejordan) andyleejordan approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@MatejKafka @andyleejordan @bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.