GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Test PowerShell Preview in CI by andyleejordan · Pull Request #2070 · PowerShell/PSScriptAnalyzer

Conversation

@andyleejordan

@andyleejordan Andy Jordan (andyleejordan) commented Mar 1, 2025

Copy link
Copy Markdown
Member

Replaces #1439.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andyleejordan
Andy Jordan (andyleejordan) requested a review from Christoph Bergmeister (bergmeister) as a code owner March 1, 2025 05:50
@andyleejordan

Andy Jordan (andyleejordan) commented Mar 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Funny day year to test this, the daily isn't available.
bergmeister reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andyleejordan Andy Jordan (andyleejordan) mentioned this pull request Mar 4, 2025
Running PowerShell Preview or Daily in CI #1439
Closed
4 of 6 tasks
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the daily branch from ed0e1a7 to 95b4553 Compare March 5, 2025 01:20
@andyleejordan

Andy Jordan (andyleejordan) commented Mar 5, 2025

Copy link
Copy Markdown
Member Author

So apparently the Daily build hasn't existed in a year. I opened PowerShell/PowerShell#25124 to correct the install script, and I don't expect this to pass until it's merged as I updated it to install the preview to ~/.powershell-preview (like the Daily was) which makes way more sense.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andyleejordan Andy Jordan (andyleejordan) mentioned this pull request Mar 5, 2025
Remove -Daily from install-powershell.ps1 since it no longer exists PowerShell/PowerShell#25124
Merged
8 of 21 tasks
@bergmeister

Christoph Bergmeister (bergmeister) commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator

Lol. But given that there are now multiple supported PowerShell versions available (LTS and current), the more valuable thing is maybe to test with those versions and the latest preview. Also, daily probably adds a bit of noise.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andyleejordan Andy Jordan (andyleejordan) changed the title Test PowerShell daily in CI Test PowerShell Preview in CI Mar 13, 2025
@andyleejordan

Andy Jordan (andyleejordan) commented Mar 13, 2025

Copy link
Copy Markdown
Member Author

Ah I didn't update the title. This will test the PowerShell Preview, I'm just waiting on my upstream PR to be merged so I don't have to install it to a -Destination manually.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the daily branch from 95b4553 to 7b352b5 Compare March 13, 2025 17:03
@andyleejordan
Andy Jordan (andyleejordan) enabled auto-merge (squash) March 13, 2025 17:04
@andyleejordan
Andy Jordan (andyleejordan) disabled auto-merge March 13, 2025 17:07
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the daily branch 2 times, most recently from 3ca30c0 to 52f3d41 Compare March 13, 2025 17:36
@andyleejordan
Andy Jordan (andyleejordan) enabled auto-merge (squash) March 13, 2025 17:45
@andyleejordan
Andy Jordan (andyleejordan) disabled auto-merge March 13, 2025 17:47
@andyleejordan
Test PowerShell Preview in CI
b44f92f 
Since the Daily no longer exists.
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the daily branch from 52f3d41 to b44f92f Compare March 13, 2025 17:48
SeeminglyScience
Patrick Meinecke (SeeminglyScience) approved these changes Mar 13, 2025
View reviewed changes

@SeeminglyScience Patrick Meinecke (SeeminglyScience) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andyleejordan
Andy Jordan (andyleejordan) merged commit bbf258b into main Mar 13, 2025
@andyleejordan
Andy Jordan (andyleejordan) deleted the daily branch March 13, 2025 18:39
@bergmeister

Christoph Bergmeister (bergmeister) commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator

Ah I didn't update the title. This will test the PowerShell Preview, I'm just waiting on my upstream PR to be merged so I don't have to install it to a -Destination manually.

Gotcha. Makes sense. But I think it would also be useful to additionally also have one run with PowerShell 7.4 since it is LTS but the CI runners always use the latest version, which is 7.5 atm. For now we could just run test suite with PS 7.4 locally, just requires manual uninstall of newer versions because some tests call into pwsh from PATH
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SeeminglyScience Patrick Meinecke (SeeminglyScience) SeeminglyScience approved these changes
@bergmeister Christoph Bergmeister (bergmeister) Awaiting requested review from bergmeister bergmeister is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@andyleejordan @bergmeister @SeeminglyScience
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.