GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update SMA version to 7.4.7 by bergmeister · Pull Request #2075 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Mar 12, 2025

Copy link
Copy Markdown
Collaborator

PR Summary

Since PowerShell 7.2 is not supported any more, we can upgrade the SMA version. Somehow 7.4.8 is not published, raised issue here: PowerShell/PowerShell#25162

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister
Update SMA version to 7.4.7
465516d
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Build label Mar 12, 2025
@bergmeister

Christoph Bergmeister (bergmeister) commented Mar 12, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator Author

Not sure why the build fails on this Andy Jordan (@andyleejordan) ? In csproj the SMA reference used to be conditional based on the target framework so don't understand how it even works now with the current 7.2 target that should only apply for PowerShell 7 builds but not 3, etc
It seems the main build is broken now for some reason as even a simple doc PR like #2076 fails with this

On another note, what do you think about a new release now that we've merged all the recent PRs? The SMA update is the only one I was thinking of doing before the release.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review March 12, 2025 20:04
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from Andy Jordan (andyleejordan) as a code owner March 12, 2025 20:04
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from Patrick Meinecke (SeeminglyScience) March 12, 2025 20:33
@andyleejordan
Merge branch 'main' into bergmeister-patch-1
387d62d
@andyleejordan

Andy Jordan (andyleejordan) commented Mar 13, 2025

Copy link
Copy Markdown
Member

Not sure why the build fails on this Andy Jordan (@andyleejordan) ? In csproj the SMA reference used to be conditional based on the target framework so don't understand how it even works now with the current 7.2 target that should only apply for PowerShell 7 builds but not 3, etc It seems the main build is broken now for some reason as even a simple doc PR like #2076 fails with this

It seems the GitHub Actions Ubuntu image is failing to add dotnet to the path when the task installs it. I fixed it in #2080 and rebased the PRs.

On another note, what do you think about a new release now that we've merged all the recent PRs? The SMA update is the only one I was thinking of doing before the release.

Yes, planning on it.
bergmeister reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andyleejordan
Andy Jordan (andyleejordan) enabled auto-merge (squash) March 13, 2025 16:56
andyleejordan
Andy Jordan (andyleejordan) approved these changes Mar 13, 2025
View reviewed changes
Comment thread Directory.Packages.props
@@ -11,7 +11,7 @@
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
<PackageVersion Include="Pluralize.NET" Version="1.0.2" />
<PackageVersion Include="PowerShellStandard.Library" Version="3.0.0-preview-02" />

@andyleejordan Andy Jordan (andyleejordan) Mar 13, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note, are we stuck on this version because of PowerShell 3 support? If not let's update it to 5.1.1.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@bergmeister Christoph Bergmeister (bergmeister) Mar 13, 2025

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Although it was an improvement to have as not all projects had to reference the psv3/4/5 reference assemblies. since it's just for referencing and not shipped, I don't mind TBH. Regarding dropping support, how about we start soft and just bump the minimum version in manifest and see what people's feedback is?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andyleejordan
Andy Jordan (andyleejordan) merged commit d4fbdc3 into main Mar 13, 2025
@andyleejordan
Andy Jordan (andyleejordan) deleted the bergmeister-patch-1 branch March 13, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SeeminglyScience Patrick Meinecke (SeeminglyScience) Awaiting requested review from SeeminglyScience
1 more reviewer
@andyleejordan Andy Jordan (andyleejordan) andyleejordan approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @andyleejordan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.