GeezerVison is showing github.com — Drop v3 and v4 support from build by andyleejordan · Pull Request #2081 · PowerShell/PSScriptAnalyzer
Conversation
This leaves all the guarded v3 and v4 implementation and test code, but starts the removal of support by dropping it from the build and updating the manifest.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also lots of conditional code in C# around PSV3/PSV4 and around PowerShell version in Pester tests. Plus the build scripts that package things up for each version.
I was thinking maybe start softer and only bump the minimum version in the manifest for now and wait for feedback following release, this way we wouldn't completely block people because they could just manually edit the manifest
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There is also lots of conditional code in C# around PSV3/PSV4 and around PowerShell version in Pester tests. Plus the build scripts that package things up for each version. I was thinking maybe start softer and only bump the minimum version in the manifest for now and wait for feedback following release, this way we wouldn't completely block people because they could just manually edit the manifest
Yes indeed. I'll cut this down a bit to start.
|
bergmeister reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Christoph Bergmeister (@bergmeister) looking at it with a fresh set of eyes I'm thinking this is a good minimal start. It's in Git so we can bring it all back if needed, but essentially it covers the build and packaging process without touching the code and tests.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Christoph Bergmeister (@bergmeister) looking at it with a fresh set of eyes I'm thinking this is a good minimal start. It's in Git so we can bring it all back if needed, but essentially it covers the build and packaging process without touching the code and tests.
Ok, I was more thinking from an end user perspective because if binaries are missing in new release, there is no hack to still be able to use it. But there is no right and wrong, just a question of speed of change and how many eggs to crack for the omelette in one go
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.