GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — v1.24.0: Thanks to all the new contributors! by andyleejordan · Pull Request #2084 · PowerShell/PSScriptAnalyzer

Conversation

@andyleejordan

@andyleejordan Andy Jordan (andyleejordan) commented Mar 14, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Christoph Bergmeister (@bergmeister) and Sean Wheeler (@sdwheeler) hoping to get this out on Monday. Need to run this by Sydney Smith (@SydneyhSmith) but thinking we should opt not try doing a preview, as one has never been done before for this module so there's a lot to fix with versioning if we did v1.24.0-preview (and then have to bump to v1.25.0 because some things get confused per Patrick Meinecke (@SeeminglyScience)).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@andyleejordan
Andy Jordan (andyleejordan) requested review from Christoph Bergmeister (bergmeister), Mikey Lombardi (He/Him) (michaeltlombardi) and Sean Wheeler (sdwheeler) as code owners March 14, 2025 23:09
bergmeister
Christoph Bergmeister (bergmeister) reviewed Mar 15, 2025
View reviewed changes
Comment thread CHANGELOG.MD Resolved

Uh oh!

There was an error while loading. Please reload this page.

bergmeister
Christoph Bergmeister (bergmeister) approved these changes Mar 15, 2025
View reviewed changes
@bergmeister

Christoph Bergmeister (bergmeister) commented Mar 15, 2025

Copy link
Copy Markdown
Collaborator

I was thinking about doing a preview before but in past when we used preview gallery for that purpose, we had only about 10 downloads even after a week. Most folks use PSSA in CI where they will first be hit with the news of a release and later when the vs-code extension consumes it. In my experience the most important aspect of slowly introducing it to users is via the powershell preview vs code extension as there are more users that can give good feedback before deciding to consume new version in stable extension.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister

Christoph Bergmeister (bergmeister) commented Mar 15, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

We need to sync our changes to docs, which I think is just the one in #1704 where UseCorrectCasing had new options added, just noticed by looking at PR again that those new options aren't documented so opened #2086 before doing the sync.

Also, it seems MSDocs changes have not been synced to PSSA so I opened PR #2085

I created a draft release here for now that then will need updating with the final changelog: https://github.com/PowerShell/PSScriptAnalyzer/releases/tag/untagged-b473ea363a2c6ccd71d6

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sdwheeler

Sean Wheeler (sdwheeler) commented Mar 15, 2025

Copy link
Copy Markdown
Contributor

Andy Jordan (@andyleejordan) Need to merge #2085 and add it to the release

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sdwheeler
Sean Wheeler (sdwheeler) reviewed Mar 15, 2025
View reviewed changes
Comment thread CHANGELOG.MD Resolved

Uh oh!

There was an error while loading. Please reload this page.

@andyleejordan
v1.24.0: Thanks to all the new contributors!
a1a3147
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the release branch from 6ac08e1 to a1a3147 Compare March 17, 2025 17:11
@andyleejordan

Andy Jordan (andyleejordan) commented Mar 17, 2025

Copy link
Copy Markdown
Member Author

I created a draft release here for now that then will need updating with the final changelog: https://github.com/PowerShell/PSScriptAnalyzer/releases/tag/untagged-b473ea363a2c6ccd71d6

I will not be able to use this as the build/release pipeline must create the draft release itself. Sorry!

bergmeister reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister

Christoph Bergmeister (bergmeister) commented Mar 17, 2025

Copy link
Copy Markdown
Collaborator

I created a draft release here for now that then will need updating with the final changelog: https://github.com/PowerShell/PSScriptAnalyzer/releases/tag/untagged-b473ea363a2c6ccd71d6

I will not be able to use this as the build/release pipeline must create the draft release itself. Sorry!

Gotcha, at least this way it saves on manual synchronisation effort because I was thinking for a moment whether we should stop maintain the changelog md file and just use releases only

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@andyleejordan

Andy Jordan (andyleejordan) commented Mar 17, 2025

Copy link
Copy Markdown
Member Author

I was thinking about doing a preview before but in past when we used preview gallery for that purpose, we had only about 10 downloads even after a week. Most folks use PSSA in CI where they will first be hit with the news of a release and later when the vs-code extension consumes it. In my experience the most important aspect of slowly introducing it to users is via the powershell preview vs code extension as there are more users that can give good feedback before deciding to consume new version in stable extension.

Yeah, that makes sense. Good to know about the low gallery update. I was planning to include it in the next preview of the extension (and would try to get that out ASAP) so we're covered there.

bergmeister reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@andyleejordan

Andy Jordan (andyleejordan) commented Mar 17, 2025

Copy link
Copy Markdown
Member Author

Gotcha, at least this way it saves on manual synchronisation effort because I was thinking for a moment whether we should stop maintain the changelog md file and just use releases only

That's what I've opted to do for other projects. In vscode-powershell for instance I modified the update script to just add:

  1. Header with version and date,
  2. the -Changes submitted when running the script (so a small descriptive sentence or two, also in the commit)
  3. a link to the GitHub release

That way there's no duplication or syncing to do.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@andyleejordan

Andy Jordan (andyleejordan) commented Mar 17, 2025

Copy link
Copy Markdown
Member Author

Andy Jordan (@andyleejordan) Need to merge #2085 and add it to the release

Merged.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister

Christoph Bergmeister (bergmeister) commented Mar 17, 2025

Copy link
Copy Markdown
Collaborator

Re-opened #2086 because it seems to have not been included in #2085

andyleejordan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bergmeister
Christoph Bergmeister (bergmeister) approved these changes Mar 17, 2025
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the outstanding, long suggestion of grouping changes that I just updated, the rest looks all good to me, ready to test a release candidate if the internal build can be shared

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from Patrick Meinecke (SeeminglyScience) March 17, 2025 19:01
@andyleejordan

Andy Jordan (andyleejordan) commented Mar 17, 2025

Copy link
Copy Markdown
Member Author

Apart from the outstanding, long suggestion of grouping changes that I just updated, the rest looks all good to me, ready to test a release candidate if the internal build can be shared

When I get the pipeline running, if I remember correctly it'll open a draft GitHub release with the module uploaded and then sit and wait for me to allow for it to publish to the gallery. And since you have access to view draft releases, you should be able to download and test it. I'll merge this and get that going.

bergmeister reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@andyleejordan @bergmeister
Update CHANGELOG.MD
0e65423
Co-authored-by: Christoph Bergmeister <[email protected]>
@andyleejordan
Andy Jordan (andyleejordan) enabled auto-merge (squash) March 17, 2025 19:59
@andyleejordan
Andy Jordan (andyleejordan) disabled auto-merge March 17, 2025 21:16
@andyleejordan
Andy Jordan (andyleejordan) merged commit 4b4a136 into main Mar 17, 2025
@andyleejordan
Andy Jordan (andyleejordan) deleted the release branch March 17, 2025 21:16
@andyleejordan

Andy Jordan (andyleejordan) commented Mar 18, 2025

Copy link
Copy Markdown
Member Author

Christoph Bergmeister (@bergmeister) the draft is up with the 1.24 nupkg, I've got 24 hours to approve its release to the gallery. Let me know before this time tomorrow if you think it's good to go and I'll finish the release and get it out!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister

Christoph Bergmeister (bergmeister) commented Mar 18, 2025

Copy link
Copy Markdown
Collaborator

Christoph Bergmeister (@bergmeister) the draft is up with the 1.24 nupkg, I've got 24 hours to approve its release to the gallery. Let me know before this time tomorrow if you think it's good to go and I'll finish the release and get it out!

Tested, especially with LTS version (PS 7.4.6), which CI does not cover and all tests passed. 🚢 it :-)

andyleejordan reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes
@michaeltlombardi Mikey Lombardi (He/Him) (michaeltlombardi) Awaiting requested review from michaeltlombardi michaeltlombardi is a code owner
@SeeminglyScience Patrick Meinecke (SeeminglyScience) Awaiting requested review from SeeminglyScience
+1 more reviewer
@sdwheeler Sean Wheeler (sdwheeler) sdwheeler left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@andyleejordan @bergmeister @sdwheeler
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.