GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix for PSUseConsistantWhiteSpace when using statement is present by AlexandraDorey · Pull Request #2091 · PowerShell/PSScriptAnalyzer

Conversation

@AlexandraDorey

@AlexandraDorey AlexandraDorey-Magnet (AlexandraDorey) commented Apr 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

The addition of an using statement can cause the PSUseConsistant white space to fail due to how the InternalVisit of the UsingStatementAst is implemented in a slightly different way than other ASTs. See issue 2089 for more details.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Alexandra Dorey
Add failng test that should pass
05e9bd4
@AlexandraDorey
AlexandraDorey-Magnet (AlexandraDorey) requested review from Andy Jordan (andyleejordan) and Christoph Bergmeister (bergmeister) as code owners April 1, 2025 22:48
@AlexandraDorey

AlexandraDorey-Magnet (AlexandraDorey) commented Apr 1, 2025

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Alexandra Dorey added 2 commits April 1, 2025 19:53
Alexandra Dorey
Try simple fix
1268930
Alexandra Dorey
Test and Fix for test
971aac4
@AlexandraDorey AlexandraDorey-Magnet (AlexandraDorey) mentioned this pull request Apr 1, 2025
PSUseConsistantWhiteSpace #2089
Closed
andyleejordan
Andy Jordan (andyleejordan) approved these changes Apr 1, 2025
View reviewed changes

@andyleejordan Andy Jordan (andyleejordan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey cool, good debugging. Read through your issue, I think you're right and this makes sense. Just approved the tests workflow.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andyleejordan Andy Jordan (andyleejordan) added the Issue - Bug label Apr 1, 2025
@AlexandraDorey AlexandraDorey-Magnet (AlexandraDorey) changed the title WIP - Fix for PSUseConsistantWhiteSpace when using statement is present Fix for PSUseConsistantWhiteSpace when using statement is present Apr 1, 2025
@AlexandraDorey AlexandraDorey-Magnet (AlexandraDorey) closed this Apr 2, 2025
@AlexandraDorey AlexandraDorey-Magnet (AlexandraDorey) reopened this Apr 2, 2025
bergmeister
Christoph Bergmeister (bergmeister) reviewed Apr 3, 2025
View reviewed changes
Comment thread NuGet.Config Resolved

Uh oh!

There was an error while loading. Please reload this page.
bergmeister
Christoph Bergmeister (bergmeister) reviewed Apr 3, 2025
View reviewed changes
Comment thread Tests/Rules/UseConsistentWhitespace.tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Apr 3, 2025
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, well done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexandraDorey reacted with laugh emoji
All reactions
  • 😄 1 reaction
AlexandraDorey-Magnet (AlexandraDorey) and others added 3 commits April 3, 2025 16:05
@AlexandraDorey @bergmeister
Update Tests/Rules/UseConsistentWhitespace.tests.ps1
5fd25d4 
Co-authored-by: Christoph Bergmeister <[email protected]>
Alexandra Dorey
Fix encoding
0fe9d12
Alexandra Dorey
Merge branch 'FixUsing' of https://github.com/AlexandraDorey/PSScript…
6bc208d 
…Analyzer into FixUsing
@AlexandraDorey

AlexandraDorey-Magnet (AlexandraDorey) commented Apr 3, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Fixed the nits up, I'm not super familiar with github but I assume I can merge my commits into one commit when the PR merges or should I do that in by branch first? Otherwise should be good to merge once the tests run again :)
andyleejordan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andyleejordan
Andy Jordan (andyleejordan) enabled auto-merge (squash) April 4, 2025 00:51
@andyleejordan

Andy Jordan (andyleejordan) commented Apr 4, 2025

Copy link
Copy Markdown
Member

Sure can!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andyleejordan
Andy Jordan (andyleejordan) merged commit 2287a13 into PowerShell:main Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes
+1 more reviewer
@andyleejordan Andy Jordan (andyleejordan) andyleejordan approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Issue - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexandraDorey @andyleejordan @bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.