GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||
GeezerVison is showing github.com — Change CommandInfo lookup for commands in the form `module\cmdletName` by liamjpeters · Pull Request #2125 · PowerShell/PSScriptAnalyzer Conversation
|
|
Liam Peters (@liamjpeters) can you rebase this so the PR checks trigger and I can merge it? Thanks! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…rm module\cmdletName
dc8786e to
8bde45d
Compare
|
My Git-Fu is not strong Andy Jordan (@andyleejordan) 😅 Did I do it? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
You did it! CI Tests are running now 😄 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
If only it had succeeded. Drat. The offending test that failed on the mac build runner: PSScriptAnalyzer/Tests/Rules/UseCorrectCasing.tests.ps1 Lines 77 to 85 in ea70855
I don't have a mac to try it on, but the failure looks like the runspace safety issue with the command info cache - an old discussion and summary in issue #1867. I've run the test in a loop and managed to get it to fail once with the same error on my Windows machine after about 20 mins of running. I've managed the same on the master branch just now:
I'm not sure how to check whether this PR makes this issue more prevalent or if it's the same as it has been and just got unlucky with the CI run. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
That seems like it's a flaky test, I'm rerunning the CI. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Code Formatter: Don't remove module names from cmdlet calls UseCorrectCasing removes<module>\ from <module>\<cmdlet> in vscode-powershell
There was an error while loading. Please reload this page.