GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add UseConsistentParametersKind rule by Haimasker · Pull Request #2149 · PowerShell/PSScriptAnalyzer

Conversation

@Haimasker

@Haimasker Denis Melnikov (Haimasker) commented Jan 3, 2026

Copy link
Copy Markdown
Contributor
  • Consistent function parameters definition

  • Rule is disabled by default

  • Possible types of preferred function parameters are: "Inline", "ParamBlock"

PR Summary

This PSScriptAnalyzer rule enforces uniform parameter definitions ("Inline" or "ParamBlock") across functions, improving code readability and maintainability.

Key Benefits:

  1. Consistency: Standardizes parameter style project-wide, making code easier to read and extend.
  2. Advanced Attributes: param block provides CmdletBinding(), OutputType(), and other advanced attributes. On the other hand, these attributes can be blocked by using inline parameters.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Haimasker
Denis Melnikov (Haimasker) requested review from a team, Christoph Bergmeister (bergmeister), Mikey Lombardi (He/Him) (michaeltlombardi) and Sean Wheeler (sdwheeler) as code owners January 3, 2026 10:07
@Haimasker

Denis Melnikov (Haimasker) commented Jan 3, 2026

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Haimasker

Denis Melnikov (Haimasker) commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

Sean Wheeler (@sdwheeler) Mikey Lombardi (He/Him) (@michaeltlombardi) Christoph Bergmeister (@bergmeister)
Sorry for additional tagging, but when a merge request review can be expected?

Thank you in advance.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister
Christoph Bergmeister (bergmeister) requested a review from Andy Jordan (andyleejordan) January 27, 2026 21:48
bergmeister
Christoph Bergmeister (bergmeister) reviewed Jan 27, 2026
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and sorry for late review. I added Andy as well as he is the main code owner.
The rule might be a bit controversial as for some folks there is no 'correct' kind, therefore I suggest to name rule UseConsistentParametersKind for consistency with other rule names

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread docs/Rules/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread docs/Rules/UseCorrectParametersKind.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread docs/Rules/UseCorrectParametersKind.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@Haimasker
Denis Melnikov (Haimasker) force-pushed the use-correct-parameters-definition-type-rule branch from 0337dfe to eb46fe4 Compare February 14, 2026 10:18
@Haimasker Denis Melnikov (Haimasker) changed the title Add UseCorrectParametersKind rule Add UseConsistentParametersKind rule Feb 14, 2026
@Haimasker
Add UseCorrectParametersKind rule
ebd9efa
* Consistent function parameters definition

* Rule is disabled by default

* Possible types of preferred function parameters are: "Inline",
"ParamBlock"
@Haimasker
Denis Melnikov (Haimasker) force-pushed the use-correct-parameters-definition-type-rule branch from eb46fe4 to ebd9efa Compare February 14, 2026 11:06
Christoph Bergmeister (bergmeister) added 2 commits February 19, 2026 10:15
@bergmeister
Merge branch 'main' into use-correct-parameters-definition-type-rule
60877c3
@bergmeister
Merge branch 'main' into use-correct-parameters-definition-type-rule
c7093fe
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Feb 19, 2026
View reviewed changes
@Haimasker

Denis Melnikov (Haimasker) commented Mar 1, 2026

Copy link
Copy Markdown
Contributor Author

Sean Wheeler (@sdwheeler) Mikey Lombardi (He/Him) (@michaeltlombardi)
Since you are the code owners of the repository, could you please review the PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister

Christoph Bergmeister (bergmeister) commented Mar 6, 2026

Copy link
Copy Markdown
Collaborator

Denis Melnikov (@Haimasker) Already pinged Andy Jordan (@andyleejordan) internally a couple weeks ago as he is main maintainer, it's on his list, please be patient.

Haimasker and andyleejordan reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@andyleejordan
Andy Jordan (andyleejordan) enabled auto-merge (squash) March 17, 2026 22:52
andyleejordan
Andy Jordan (andyleejordan) approved these changes Mar 17, 2026
View reviewed changes
@andyleejordan
Andy Jordan (andyleejordan) merged commit 520d2aa into PowerShell:main Mar 17, 2026
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@andyleejordan

Andy Jordan (andyleejordan) commented Mar 17, 2026

Copy link
Copy Markdown
Member

Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes
@sdwheeler Sean Wheeler (sdwheeler) Awaiting requested review from sdwheeler
@michaeltlombardi Mikey Lombardi (He/Him) (michaeltlombardi) Awaiting requested review from michaeltlombardi michaeltlombardi is a code owner
+2 more reviewers
@hrxn HRXN (hrxn) hrxn left review comments
@andyleejordan Andy Jordan (andyleejordan) andyleejordan approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Haimasker @bergmeister @andyleejordan @hrxn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.