GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove Conditional Compilation and Runtime Checks for v3 or v4 by liamjpeters · Pull Request #2150 · PowerShell/PSScriptAnalyzer

Conversation

@liamjpeters

@liamjpeters Liam Peters (liamjpeters) commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

PR Summary

The minimum PS version the module can be loaded in is 5.1 (since e849068).

All of the conditional compilation checks around PSV3 and PSV4 can be removed/simplified.

Similarly the runtime checks for anything less than major version 5 can be simplified.

There are probably still some functions acting as compat shims to bridge functionality missing in 3 or 4 which could also be replaced.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@liamjpeters
Liam Peters (liamjpeters) requested review from a team and Christoph Bergmeister (bergmeister) as code owners January 12, 2026 13:57
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Jan 30, 2026
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, when we upped minimum version to 5 in last release, we left code deliberately as-is in case there was feedback to pushback on that and allow people to . Whilst it has been noticed, I think we're ready to drop the code now as I'd like a new release in the next weeks or months (so will also go through other PRs). Thanks for taking the time :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
andyleejordan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from Andy Jordan (andyleejordan) January 30, 2026 17:00
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Build label Jan 30, 2026
andyleejordan
Andy Jordan (andyleejordan) approved these changes Feb 18, 2026
View reviewed changes

@andyleejordan Andy Jordan (andyleejordan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Liam Peters (liamjpeters) added 3 commits February 18, 2026 21:03
@liamjpeters
Remove conditional compilation gates using PSV3 and PSV4
f978db3
@liamjpeters
Replace HashtableAst.SafeGetValue() compatibility shim with actual im…
060673a 
…plementation
@liamjpeters
Remove/simplify conditional checks which would would always be met wi…
db7f0c9 
…th a minimum version of 5.1 (no longer supporting v3 or v4)
@liamjpeters
Liam Peters (liamjpeters) force-pushed the RemoveV3AndV4 branch from f094f2f to db7f0c9 Compare February 18, 2026 21:03
@bergmeister
Christoph Bergmeister (bergmeister) merged commit aba29c3 into PowerShell:main Feb 19, 2026
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Feb 19, 2026
AlignAssignmentStatement overhaul to fix issues and include handing of Enums. #2132
Merged
5 of 6 tasks
@liamjpeters
Liam Peters (liamjpeters) deleted the RemoveV3AndV4 branch February 20, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes
+1 more reviewer
@andyleejordan Andy Jordan (andyleejordan) andyleejordan approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@liamjpeters @andyleejordan @bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.