GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix typos in resource strings and associated C# references by casuffitsharp · Pull Request #2163 · PowerShell/PSScriptAnalyzer

Conversation

@casuffitsharp

@casuffitsharp Henrique Azevedo (casuffitsharp) commented Mar 8, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Correct misspellings in Strings.resx (e.g., 'equaltiy', 'whitepsace')
  • Rename misspelled resource keys for consistency
  • Update C# rule files to reflect new resource key names

PR Summary

This PR fixes several typos and grammatical errors identified in the Rules/Strings.resx file. It also renames resource keys that contained misspellings. Corresponding references in C# rule files have been updated to maintain build stability.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@casuffitsharp
Fix typos and grammatical errors in resource strings
b1b951b 
- Correct misspellings in Strings.resx (e.g., 'equaltiy', 'whitepsace')
- Rename misspelled resource keys for consistency
- Update C# rule files to reflect new resource key names
Copilot AI review requested due to automatic review settings March 8, 2026 04:16
@casuffitsharp
Henrique Azevedo (casuffitsharp) requested review from a team and Christoph Bergmeister (bergmeister) as code owners March 8, 2026 04:16
Copilot started reviewing on behalf of Henrique Azevedo (casuffitsharp) March 8, 2026 04:17
View session
@casuffitsharp

Henrique Azevedo (casuffitsharp) commented Mar 8, 2026

Copy link
Copy Markdown
Contributor Author

Henrique Azevedo (@casuffitsharp) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Copilot AI reviewed Mar 8, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up user-facing rule resource strings by correcting typos/grammar and aligns C# rule implementations to renamed .resx resource keys so the strongly-typed Strings references continue to compile.

Changes:

  • Fixed multiple typos/wording issues in Rules/Strings.resx.
  • Renamed misspelled resource keys to correctly spelled names.
  • Updated C# rule files to reference the new resource key/property names.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
Rules/UseShouldProcessForStateChangingFunctions.cs Updates Strings.* reference to the corrected ...Description resource key.
Rules/UseLiteralInitializerForHashtable.cs Replaces misspelled resource property names with corrected UseLiteralInitializer... keys.
Rules/PossibleIncorrectComparisonWithNull.cs Updates to the corrected ...SuggestedCorrectionDescription resource key.
Rules/Strings.resx Fixes typos/grammar in values and renames several misspelled resource keys.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Rules/Strings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Rules/Strings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.
@casuffitsharp
Strings: fix grammar and casing in rule descriptions
b370c4e 
- Combine sentence fragment in AvoidUsingEmptyCatchBlockDescription for better flow
- Update 'Whatif' to 'WhatIf' in UseSupportsShouldProcess strings to match PowerShell naming conventions
liamjpeters
Liam Peters (liamjpeters) reviewed Mar 8, 2026
View reviewed changes

@liamjpeters Liam Peters (liamjpeters) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing those typos. Just one suggestion 🙂

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Rules/Strings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Rules/Strings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.
@casuffitsharp
Strings: improve AvoidUsingEmptyCatchBlockDescription phrasing
2cb0b07
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from Copilot March 9, 2026 18:56
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Mar 9, 2026
View reviewed changes
Copilot started reviewing on behalf of Christoph Bergmeister (bergmeister) March 9, 2026 18:57
View session
Copilot AI reviewed Mar 9, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Mar 9, 2026
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
casuffitsharp reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bergmeister
Christoph Bergmeister (bergmeister) requested review from Andy Jordan (andyleejordan) and Sean Wheeler (sdwheeler) March 9, 2026 19:03
sdwheeler
Sean Wheeler (sdwheeler) approved these changes Mar 9, 2026
View reviewed changes

@sdwheeler Sean Wheeler (sdwheeler) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
casuffitsharp reacted with thumbs up emoji bergmeister reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction
@andyleejordan
Andy Jordan (andyleejordan) merged commit b3653a9 into PowerShell:main Mar 18, 2026
8 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes
@andyleejordan Andy Jordan (andyleejordan) Awaiting requested review from andyleejordan
+2 more reviewers
@liamjpeters Liam Peters (liamjpeters) liamjpeters left review comments
@sdwheeler Sean Wheeler (sdwheeler) sdwheeler approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@casuffitsharp @liamjpeters @bergmeister @sdwheeler @andyleejordan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.