GeezerVison is showing github.com — Upgrade Pester to version 6 by liamjpeters · Pull Request #2194 · PowerShell/PSScriptAnalyzer
Conversation
PR Summary
Windows PowerShell CI tests were not pinned to a Pester version and so used the latest stable. This changed recently to v6 (well done on the release Jakub Jareš (@nohwnd) 🎉).
Windows PowerShell CI was broken - complaining of a missing -Pending parameter, which has been removed in v6.
Instead of just pinning the Windows PowerShell version to 5.7.1, the changes required for v6 compatibility were minimal, so those changes were made instead.
Claude and I used the v5-v6 migration guide and skill to update to v6.
I've now pinned the Windows PowerShell version in line with the tools/installPSResources.ps1 version - settling on the current 6.0.1. I Can't find a tidy way to specify the version once and have it used in both places. Open to suggestions if there's a good way.
Note: This does not do the Should -Be to Should-Be migration that is optional for this version change and documented here.
PR Checklist
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
nohwnd reacted with hooray emoji
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the repo’s tooling, CI, and test suite to be compatible with (and pinned to) Pester v6, addressing Windows PowerShell CI failures caused by the removal of the -Pending parameter.
Changes:
- Pinned Pester to
6.0.1 in tooling (installPSResources.ps1) and Windows PowerShell CI (ci-test.yml).
- Migrated affected Pester tests from
-Pending to -Skip for v6 compatibility.
- Updated README references to Pester v6 / minimum required Pester version.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File |
Description |
| tools/installPSResources.ps1 |
Bumps the pinned Pester version used by tooling installs to 6.0.1. |
| Tests/Rules/UseToExportFieldsInManifest.tests.ps1 |
Replaces -Pending usage with -Skip for Pester v6 compatibility. |
| Tests/Rules/UseIdenticalMandatoryParametersForDSC.tests.ps1 |
Replaces -Pending usage with -Skip for Pester v6 compatibility. |
| README.md |
Updates documentation to reference Pester v6 and minimum required version. |
| .github/workflows/ci-test.yml |
Pins Pester version in Windows PowerShell CI to avoid unintentional upgrades. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
I was too late, sorry but thanks so much
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.