GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add rule template and documentation by sdwheeler · Pull Request #2215 · PowerShell/PSScriptAnalyzer

Conversation

@sdwheeler

@sdwheeler Sean Wheeler (sdwheeler) commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Add rule template and documentation

  • Fixes AB#633680

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sdwheeler
Add rule template and documentation
2a4e7d4
@sdwheeler
Sean Wheeler (sdwheeler) requested review from a team and Mikey Lombardi (He/Him) (michaeltlombardi) as code owners September 17, 2026 12:33
Copilot AI lite review requested due to automatic review settings September 17, 2026 12:33
Copilot started reviewing on behalf of Sean Wheeler (sdwheeler) September 17, 2026 12:34
View session
@sdwheeler Sean Wheeler (sdwheeler) mentioned this pull request Sep 17, 2026
Add new AvoidUsingNewObject rule #2186
Open
6 tasks done
Copilot AI reviewed Sep 17, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The template contains invalid YAML placeholders and heading/link inconsistencies that should be corrected before approval.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds a reusable PSScriptAnalyzer rule documentation template and authoring guidance.

Changes:

  • Defines standard article structure and placeholders.
  • Documents required and optional sections.
  • Provides configuration, suppression, and example guidance.
File summaries
File Summary
docs/rule-template.md Adds the reusable rule documentation template.
docs/rule-template-docs.md Documents how to complete the template.
Review details

Suppressed comments (4)

docs/rule-template.md:5

  • The frontmatter is not valid YAML while the placeholders are present: an unquoted scalar beginning with {{ is parsed as a flow collection and causes frontmatter parsers to fail. Since this is a documentation template, keep the template itself parseable by quoting the placeholder values (and preserve the quotes when authors replace them).
description: {{Brief description of the rule behavior}}
ms.date: {{MM/DD/YYYY}}
ms.topic: reference
title: {{RuleName}}

docs/rule-template.md:40

  • This introduces a second top-level examples section immediately after the required ## Example, so anyone copying the template gets a redundant empty section and an inconsistent hierarchy. Keep one ## Example section and place the scenario heading directly beneath it as the optional additional example structure.
## Examples

### {{Scenario name}}

docs/rule-template.md:73

  • The repository's rule articles make Parameters an H3 under the configuration section and individual settings H4 headings (for example, docs/Rules/PlaceOpenBrace.md:31-45). Making Parameters an H2 and each setting an H3 breaks the documented heading hierarchy and conflicts with the guidance file.
## Parameters

### {{SettingName}}

docs/rule-template.md:95

  • This reference link has no definition in this file, and the repository does not contain a using-scriptanalyzer.md target at the referenced relative path, so every article copied from the template will publish a broken Further reading link. Point this reference to the same Microsoft Learn URL used by the repository README (or add the intended local document).
[02]: ../using-scriptanalyzer.md
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread docs/rule-template-docs.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread docs/rule-template-docs.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Sean Wheeler (sdwheeler) added 2 commits September 17, 2026 07:45
@sdwheeler
Correct H-levels for Parameters
523c7b4
@sdwheeler
Remove duplicated examples
d6b3b47
michaeltlombardi
Mikey Lombardi (He/Him) (michaeltlombardi) approved these changes Sep 18, 2026
View reviewed changes
@michaeltlombardi
Mikey Lombardi (He/Him) (michaeltlombardi) merged commit 168dcbd into PowerShell:main Sep 18, 2026
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@michaeltlombardi Mikey Lombardi (He/Him) (michaeltlombardi) michaeltlombardi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sdwheeler @michaeltlombardi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.